Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Proto columns #1991

Merged
merged 19 commits into from
May 15, 2024
Merged

Conversation

harshachinta
Copy link
Contributor

@harshachinta harshachinta commented Feb 2, 2024

This PR adds support for Proto Columns

gauravpurohit06 and others added 2 commits August 7, 2023 11:57
* feat: Generated Proto Changes

Changes need to be reverted.

* feat: Implementation for Proto Message & Enum

-Adding Logic for Serialization & Deserialization
-New Type Codes and utilities

* feat: Proto static files and typings and generated descriptors

* sample: Adding DML, DQL, DML, table insert & read samples.

* style: Lint

* test: Adding unit tests

* refactor: minor refactoring

* refactor: minor refactoring

* test: Adding integration tests

* docs: Adding docs

* test: Adding sample Integration Tests

* refactor: Minor refactoring and updating comments/docs.

* test: Making test fixes

* refactor: Minor refactoring and lint fixes

* refactor: Minor refactoring and lint fixes

* Updating docs and minor changes.

* test: fixing test

* refactor: minor changes

* refactor: minor refactoring

* docs: Updating docs & comments
@harshachinta harshachinta requested review from a team as code owners February 2, 2024 04:49
@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Feb 2, 2024
Copy link

snippet-bot bot commented Feb 2, 2024

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/nodejs-spanner API. label Feb 2, 2024
@harshachinta harshachinta added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 2, 2024
@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 7, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 7, 2024
@harshachinta harshachinta added the owlbot:run Add this label to trigger the Owlbot post processor. label May 7, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 7, 2024
Copy link

Warning: This pull request is touching the following templated files:

@harshachinta harshachinta requested a review from surbhigarg92 May 8, 2024 04:07
@harshachinta harshachinta removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 10, 2024
src/codec.ts Show resolved Hide resolved
src/codec.ts Show resolved Hide resolved
src/partial-result-stream.ts Show resolved Hide resolved
system-test/spanner.ts Show resolved Hide resolved
system-test/spanner.ts Show resolved Hide resolved
samples/system-test/spanner.test.js Dismissed Show resolved Hide resolved
samples/database-get-ddl.js Outdated Show resolved Hide resolved
@harshachinta harshachinta merged commit ae59c7f into main May 15, 2024
19 checks passed
@harshachinta harshachinta deleted the proto-column-enhancement-alpha branch May 15, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants