Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hierarchical namespace and folders features #2445

Merged
merged 11 commits into from
Mar 14, 2024

Conversation

JesseLovelace
Copy link
Contributor

Adds support for hierarchical namespace and folders. Copied over from an internal workspace

@JesseLovelace JesseLovelace requested a review from frankyn March 12, 2024 23:09
@JesseLovelace JesseLovelace requested a review from a team as a code owner March 12, 2024 23:09
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/java-storage API. labels Mar 12, 2024
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Mar 12, 2024
Copy link
Collaborator

@BenWhitehead BenWhitehead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superficially LGTM, waiting on @frankyn for final approval as I believe he's more familiar with this

@JesseLovelace JesseLovelace added the automerge Merge the pull request once unit tests and other checks pass. label Mar 13, 2024
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 14, 2024
@JesseLovelace JesseLovelace requested a review from a team as a code owner March 14, 2024 17:12
@JesseLovelace JesseLovelace added the automerge Merge the pull request once unit tests and other checks pass. label Mar 14, 2024
@JesseLovelace JesseLovelace merged commit 8074fff into main Mar 14, 2024
22 of 23 checks passed
@JesseLovelace JesseLovelace deleted the includefolders branch March 14, 2024 17:37
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants