-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add ability to create a PCU Prefix at the object level #2345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
Pull request size is medium.
api: storage
Issues related to the googleapis/java-storage API.
labels
Jan 4, 2024
sydney-munro
force-pushed
the
prefix-dest
branch
from
January 4, 2024 17:39
522f4ca
to
134f8b4
Compare
frankyn
reviewed
Jan 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just single clarifying point.
...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java
Show resolved
Hide resolved
...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java
Outdated
Show resolved
Hide resolved
frankyn
added
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Jan 5, 2024
sydney-munro
force-pushed
the
prefix-dest
branch
from
January 5, 2024 20:28
0a6a349
to
0115605
Compare
frankyn
reviewed
Jan 18, 2024
...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java
Outdated
Show resolved
Hide resolved
...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java
Outdated
Show resolved
Hide resolved
sydney-munro
force-pushed
the
prefix-dest
branch
from
January 18, 2024 21:40
e6d8eab
to
b2fe993
Compare
frankyn
approved these changes
Jan 18, 2024
frankyn
removed
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Jan 18, 2024
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jan 22, 2024
🤖 I have created a release *beep* *boop* --- ## [2.32.0](https://togithub.com/googleapis/java-storage/compare/v2.31.0...v2.32.0) (2024-01-22) ### Features * Add ability to create a PCU Prefix at the object level ([#2345](https://togithub.com/googleapis/java-storage/issues/2345)) ([d39a4e4](https://togithub.com/googleapis/java-storage/commit/d39a4e46eb429b77ee75d822521ed31567ed5ec4)) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.22.0 ([#2363](https://togithub.com/googleapis/java-storage/issues/2363)) ([e2e2d7e](https://togithub.com/googleapis/java-storage/commit/e2e2d7ef5e2bc353357053df7bc26adeb0fe074a)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: storage
Issues related to the googleapis/java-storage API.
size: m
Pull request size is medium.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature enabled the user to create a prefix that will be unique per parallel composite upload. If the user specifies a prefix the prefix will be appended to the ultimate object name which will be appended to the part name to create a staging area for objects per PCU.
If the user does not specify a prefix then the parts will simply be created at the level of the ultimate object name.