Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ability to create a PCU Prefix at the object level #2345

Merged
merged 9 commits into from
Jan 19, 2024

Conversation

sydney-munro
Copy link
Collaborator

This feature enabled the user to create a prefix that will be unique per parallel composite upload. If the user specifies a prefix the prefix will be appended to the ultimate object name which will be appended to the part name to create a staging area for objects per PCU.

If the user does not specify a prefix then the parts will simply be created at the level of the ultimate object name.

@sydney-munro sydney-munro requested a review from a team as a code owner January 4, 2024 17:33
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/java-storage API. labels Jan 4, 2024
@sydney-munro sydney-munro requested a review from frankyn January 4, 2024 17:34
Copy link
Member

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just single clarifying point.

@frankyn frankyn added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 5, 2024
@sydney-munro sydney-munro requested a review from a team as a code owner January 18, 2024 17:52
@sydney-munro sydney-munro requested a review from frankyn January 18, 2024 21:50
@frankyn frankyn removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 18, 2024
@sydney-munro sydney-munro merged commit d39a4e4 into main Jan 19, 2024
22 checks passed
@sydney-munro sydney-munro deleted the prefix-dest branch January 19, 2024 17:28
gcf-merge-on-green bot pushed a commit that referenced this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants