Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add retries for auth service errors which are tagged Retryable #2026

Merged
merged 1 commit into from
May 23, 2023
Merged

fix: add retries for auth service errors which are tagged Retryable #2026

merged 1 commit into from
May 23, 2023

Conversation

BenWhitehead
Copy link
Collaborator

No description provided.

@BenWhitehead BenWhitehead added the owlbot:ignore instruct owl-bot to ignore a PR label May 22, 2023
@BenWhitehead BenWhitehead requested a review from a team as a code owner May 22, 2023 20:45
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/java-storage API. labels May 22, 2023
TimurSadykov
TimurSadykov approved these changes May 22, 2023
View reviewed changes
Copy link

@TimurSadykov TimurSadykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tritone
tritone approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@BenWhitehead BenWhitehead merged commit 3675514 into main May 23, 2023
@BenWhitehead BenWhitehead deleted the auth-retry branch May 23, 2023 20:08
@release-please release-please bot mentioned this pull request May 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydney-munro sydney-munro sydney-munro approved these changes

@tritone tritone tritone approved these changes

@TimurSadykov TimurSadykov TimurSadykov approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/java-storage API. owlbot:ignore instruct owl-bot to ignore a PR size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BenWhitehead @TimurSadykov @tritone @sydney-munro