Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Handle generation numbers in BlobId#{to,from}GsUtilUri #1929

Merged
merged 3 commits into from
Apr 5, 2023
Merged

feat: Handle generation numbers in BlobId#{to,from}GsUtilUri #1929

merged 3 commits into from
Apr 5, 2023

Conversation

davidmandle
Copy link
Contributor

Fixes #1928 ☕️

@davidmandle davidmandle requested a review from a team as a code owner March 7, 2023 19:38
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Mar 7, 2023
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Mar 7, 2023 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/java-storage API. label Mar 7, 2023
@davidmandle davidmandle changed the title Modify BlobId#{to,from}GsUtilUri to handle generation numbers. feat: Handle generation numbers in BlobId#{to,from}GsUtilUri Mar 7, 2023
@davidmandle
Copy link
Contributor Author

@JesseLovelace might you be able to take a look at this? Or is there another code owner I can reach out to?

BenWhitehead
BenWhitehead requested changes Apr 4, 2023
View reviewed changes
Copy link
Collaborator

@BenWhitehead BenWhitehead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I think it looks reasonable. One small request on the code structure before approval.

google-cloud-storage/src/main/java/com/google/cloud/storage/BlobId.java Outdated Show resolved Hide resolved
@BenWhitehead BenWhitehead added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 4, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 4, 2023
@davidmandle
Copy link
Contributor Author

Thanks for taking a look!

@davidmandle davidmandle requested a review from BenWhitehead April 4, 2023 17:29
@BenWhitehead BenWhitehead added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 4, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 4, 2023
@davidmandle
Copy link
Contributor Author

This appears to have been impacted by a test flake: #1748 .... tests may need to be re-run.

@davidmandle
Copy link
Contributor Author

I believe this is currently blocked on approval of the requested changes.

@BenWhitehead
Copy link
Collaborator

Change not impacted by owlbot, merging

@BenWhitehead BenWhitehead merged commit 0a033b3 into googleapis:main Apr 5, 2023
@release-please release-please bot mentioned this pull request Apr 5, 2023
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Apr 12, 2023
@release-please
chore(main): release 2.22.0 (#1970)
1ff4c51 
🤖 I have created a release *beep* *boop*
---


## [2.22.0](https://togithub.com/googleapis/java-storage/compare/v2.21.0...v2.22.0) (2023-04-12)


### Features

* Add matchGlob parameter to BlobListOption ([#1965](https://togithub.com/googleapis/java-storage/issues/1965)) ([93be97a](https://togithub.com/googleapis/java-storage/commit/93be97a9ae061241f510cbeb566f9f839063faa0))
* Handle generation numbers in BlobId#{to,from}GsUtilUri ([#1929](https://togithub.com/googleapis/java-storage/issues/1929)) ([0a033b3](https://togithub.com/googleapis/java-storage/commit/0a033b36a2be7e1d92c8b2f7323f2851005034cf))
* Implement GrpcStorageImpl#{get,list,create,delete}Notification ([#1958](https://togithub.com/googleapis/java-storage/issues/1958)) ([830052b](https://togithub.com/googleapis/java-storage/commit/830052b3f26337f50770436784f0ea9f3366dbca))
* Make it possible to disable the buffer of ReadChannels returned from Storage.reader ([#1974](https://togithub.com/googleapis/java-storage/issues/1974)) ([702ab2b](https://togithub.com/googleapis/java-storage/commit/702ab2bb1ceb9f428296591adc6e09023b4a8484))


### Bug Fixes

* Update GrpcStorageOptions to set allowNonDefaultServiceAccount = true ([#1977](https://togithub.com/googleapis/java-storage/issues/1977)) ([f1b9493](https://togithub.com/googleapis/java-storage/commit/f1b94930509c87ecbdbe6627fec6118305331780))


### Documentation

* Update spec for WriteObjectRequest.object_size to clarify that it applies to both one-shot and resumable writes ([#1976](https://togithub.com/googleapis/java-storage/issues/1976)) ([7354e19](https://togithub.com/googleapis/java-storage/commit/7354e198521384cd2b8583f073217a5a6cb74fe0))


### Dependencies

* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.7.0 ([#1978](https://togithub.com/googleapis/java-storage/issues/1978)) ([1f7e9c9](https://togithub.com/googleapis/java-storage/commit/1f7e9c9130a9516acfcdfda4b23e642fbe799146))
* Update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.21 ([#1979](https://togithub.com/googleapis/java-storage/issues/1979)) ([d6accdf](https://togithub.com/googleapis/java-storage/commit/d6accdf9c81419728c39a61e348a61683dc117ad))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
BenWhitehead added a commit that referenced this pull request Apr 26, 2023
@BenWhitehead
fix: introduce new BlobId#toGsUtilUriWithGeneration
37c728e 
When BlobId#toGsUtilUri was updated to output generation if defined, this broken older clients ability to parse the value via BlobId#fromGsUtilUri. This adds the new method toGsUtilUriWithGeneration to explicitly opt in to generation being okay in the output.

Related to #1928
Related to #1929
BenWhitehead added a commit that referenced this pull request Apr 26, 2023
@BenWhitehead
fix: introduce new BlobId#toGsUtilUriWithGeneration
8a4241b 
When BlobId#toGsUtilUri was updated to output generation if defined, this broken older clients ability to parse the value via BlobId#fromGsUtilUri. This adds the new method toGsUtilUriWithGeneration to explicitly opt in to generation being okay in the output.

Related to #1928
Related to #1929
@BenWhitehead BenWhitehead mentioned this pull request Apr 26, 2023
Merged
sydney-munro pushed a commit that referenced this pull request Apr 26, 2023
@BenWhitehead
fix: introduce new BlobId#toGsUtilUriWithGeneration (#1998)
68de5c7 
When BlobId#toGsUtilUri was updated to output generation if defined, this broken older clients ability to parse the value via BlobId#fromGsUtilUri. This adds the new method toGsUtilUriWithGeneration to explicitly opt in to generation being okay in the output.

Related to #1928
Related to #1929
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenWhitehead BenWhitehead Awaiting requested review from BenWhitehead

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/java-storage API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle generation numbers in BlobId#{to,from}GsUtilUri
3 participants
@davidmandle @BenWhitehead @yoshi-kokoro