feat: implement GrpcStorageImpl#createDefaultAcl & GrpcStorageImpl#updateDefaultAcl #1806
Conversation
product-auto-label
bot
added
size: m
BenWhitehead
force-pushed
the
grpc/defaultAcl/create
branch
2 times, most recently
from
db4e8ff to
8fd605b
Compare
BenWhitehead
changed the title
BenWhitehead
force-pushed
the
grpc/defaultAcl/create
branch
from
909faf5 to
da718a5
Compare
| .map(codecs.objectAcl()::decode); | ||
|
|
||
| return first.orElseThrow( | ||
| () -> new StorageException(404, "Acl update call success, but not in response")); |
There was a problem hiding this comment.
Hopefully never, but since we have to search for the updated acl in the response, if the response somehow doesn't included the updated acl we need to signal that somehow. 404 here doesn't feel totally correct, but I'm not sure 500 is better. What do you think?
There was a problem hiding this comment.
Not sure it's necessary tbh, you can only have up to 100 acls associated to a bucket or object;
Thinking we just rely on the service response code in this case unless I'm misunderstanding.
There was a problem hiding this comment.
I spoke with @frankyn offline, we came to the consensus that instead of returning an HTTP status code here, insead we will return undefined 0 to signal that it's purely a client side issue, not any system issue.
BenWhitehead
force-pushed
the
grpc/defaultAcl/create
branch
from
da718a5 to
cb0f538
Compare
google-cloud-storage/src/main/java/com/google/cloud/storage/GrpcStorageImpl.java
Show resolved
Hide resolved
google-cloud-storage/src/test/java/com/google/cloud/storage/it/ITAccessTest.java
Show resolved
Hide resolved
…nd in the update response
No description provided.