Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement GrpcStorageImpl#getDefaultAcl #1802

Merged
merged 1 commit into from
Dec 8, 2022
Merged

feat: implement GrpcStorageImpl#getDefaultAcl #1802

merged 1 commit into from
Dec 8, 2022

Conversation

BenWhitehead
Copy link
Collaborator

No description provided.

@BenWhitehead BenWhitehead requested a review from a team as a code owner December 8, 2022 00:05
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/java-storage API. labels Dec 8, 2022
@BenWhitehead BenWhitehead force-pushed the grpc/defaultAcl/read-list branch from bc547ad to 13951aa Compare December 8, 2022 00:06
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner December 8, 2022 00:07
@BenWhitehead BenWhitehead added the owlbot:ignore instruct owl-bot to ignore a PR label Dec 8, 2022
@BenWhitehead BenWhitehead force-pushed the grpc/defaultAcl/read-list branch from 4c3d02a to 13951aa Compare December 8, 2022 00:08
@BenWhitehead BenWhitehead force-pushed the grpc/defaultAcl/read-list branch from 13951aa to 6e9a3ae Compare December 8, 2022 18:04
sydney-munro
sydney-munro approved these changes Dec 8, 2022
View reviewed changes
Copy link
Collaborator

@sydney-munro sydney-munro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BenWhitehead BenWhitehead merged commit b9b7c49 into main Dec 8, 2022
@BenWhitehead BenWhitehead deleted the grpc/defaultAcl/read-list branch December 8, 2022 19:15
@release-please release-please bot mentioned this pull request Dec 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydney-munro sydney-munro sydney-munro approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/java-storage API. owlbot:ignore instruct owl-bot to ignore a PR size: m Pull request size is medium.
Projects
None yet
Milestone
Storage gRPC implementation
Development

Successfully merging this pull request may close these issues.
2 participants
@BenWhitehead @sydney-munro