-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Copy all storage samples from java-docs-samples #1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warning: This pull request is touching the following templated files:
|
product-auto-label
bot
added
api: storage
Issues related to the googleapis/java-storage API.
samples
Issues that are directly related to samples.
labels
Feb 16, 2022
JesseLovelace
changed the title
Copy all storage samples from java-docs-samples
(feat) Copy all storage samples from java-docs-samples
Feb 16, 2022
JesseLovelace
changed the title
(feat) Copy all storage samples from java-docs-samples
feat: Copy all storage samples from java-docs-samples
Feb 16, 2022
BenWhitehead
changed the title
feat: Copy all storage samples from java-docs-samples
docs: Copy all storage samples from java-docs-samples
Feb 17, 2022
I changed the PR type to docs so it doesn't cause a minor version bump. |
In the ultimate commit comment I think it'd be good to include a link to the SHA that the samples were imported from. Just in case we ever need to try and backtrace something. |
JesseLovelace
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Mar 3, 2022
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Mar 3, 2022
JesseLovelace
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Mar 3, 2022
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Mar 3, 2022
JesseLovelace
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Mar 3, 2022
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Mar 3, 2022
JesseLovelace
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Mar 4, 2022
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: storage
Issues related to the googleapis/java-storage API.
samples
Issues that are directly related to samples.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal bug b/190102205.
Makes a copy of all (published) samples from java-docs-samples. Leaves behind everything that isn't published.
After this is merged, all docs pages will be updated to refer to these instead of the samples in java-docs-samples. Then, the java-docs-samples samples will be deleted.
This will allow anyone developing new library features to include samples in the same PR