Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spanner): getEdition() is returning null for Instance #3496

Merged

Conversation

sakthivelmanii
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes b/379542220

If you write sample code, please follow the samples format.

@sakthivelmanii sakthivelmanii requested a review from a team as a code owner November 22, 2024 03:21
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/java-spanner API. labels Nov 22, 2024
@sakthivelmanii sakthivelmanii merged commit 77cb585 into googleapis:main Nov 23, 2024
31 checks passed
svc-squareup-copybara pushed a commit to cashapp/misk that referenced this pull request Dec 4, 2024
| Package | Type | Package file | Manager | Update | Change |
|---|---|---|---|---|---|
|
[com.google.cloud:google-cloud-spanner](https://github.com/googleapis/java-spanner)
| dependencies | misk/gradle/libs.versions.toml | gradle | minor |
`6.81.2` -> `6.82.0` |
| [org.flywaydb:flyway-gradle-plugin](https://flywaydb.org)
([source](https://github.com/flyway/flyway)) | dependencies |
misk/gradle/libs.versions.toml | gradle | patch | `11.0.0` -> `11.0.1` |
| [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.29.24` -> `2.29.27` |
|
[software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava)
| dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.29.24` -> `2.29.27` |
| [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.29.24` -> `2.29.27` |
| [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.29.24` -> `2.29.27` |
| [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.29.24` -> `2.29.27` |
| [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.29.24` -> `2.29.27` |

---

### Release Notes

<details>
<summary>googleapis/java-spanner
(com.google.cloud:google-cloud-spanner)</summary>

###
[`v6.82.0`](https://github.com/googleapis/java-spanner/blob/HEAD/CHANGELOG.md#6820-2024-12-04)

##### Features

- Add option for retrying DML as PDML
([#&#8203;3480](googleapis/java-spanner#3480))
([b545557](googleapis/java-spanner@b545557))
- Add the last statement option to ExecuteSqlRequest and
ExecuteBatchDmlRequest
([76ab801](googleapis/java-spanner@76ab801))

##### Bug Fixes

- **deps:** Update the Java code generator (gapic-generator-java) to
2.50.0
([76ab801](googleapis/java-spanner@76ab801))
- Shutdown built in metrics meter provider
([#&#8203;3518](googleapis/java-spanner#3518))
([c935e2e](googleapis/java-spanner@c935e2e))
- **spanner:** GetEdition() is returning null for Instance
([#&#8203;3496](googleapis/java-spanner#3496))
([77cb585](googleapis/java-spanner@77cb585))

##### Dependencies

- Update dependency commons-io:commons-io to v2.18.0
([#&#8203;3492](googleapis/java-spanner#3492))
([5c8b3ad](googleapis/java-spanner@5c8b3ad))

##### Documentation

- Add Multi Region Encryption samples
([#&#8203;3524](googleapis/java-spanner#3524))
([316f971](googleapis/java-spanner@316f971))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am
every weekday" in timezone Australia/Melbourne, Automerge - At any time
(no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://github.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

GitOrigin-RevId: 20ef292c9bda52c160283aea5bcf8ed8c6a44e21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants