perf: only capture the call stack if the call is actually async #2471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only capture the call stack of a caller of one of the Connection API methods if the top-level call was an async call. For synchronous calls, we do not need to additionally capture the call stack, as any exception will include the current call stack of the synchronous method call.
product-auto-label
bot
added
size: l
rajatbhatta
approved these changes
May 31, 2023
...cloud-spanner/src/test/java/com/google/cloud/spanner/connection/ExceptionMockServerTest.java
Outdated
Show resolved
Hide resolved
...cloud-spanner/src/test/java/com/google/cloud/spanner/connection/ExceptionMockServerTest.java
Outdated
Show resolved
Hide resolved
olavloite
added
the
automerge
gcf-merge-on-green
bot
deleted the
only-create-async-exception-for-async-calls
branch
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
May 31, 2023
🤖 I have created a release *beep* *boop* --- ## [6.42.3](https://togithub.com/googleapis/java-spanner/compare/v6.42.2...v6.42.3) (2023-05-31) ### Performance Improvements * Only capture the call stack if the call is actually async ([#2471](https://togithub.com/googleapis/java-spanner/issues/2471)) ([ae9c8ad](https://togithub.com/googleapis/java-spanner/commit/ae9c8add484bc0f7808571cbcffb7b352d6ed739)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only capture the call stack of a caller of one of the Connection API methods if the top-level call was an async call. For synchronous calls, we do not need to additionally capture the call stack, as any exception will include the current call stack of the synchronous method call.