-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: target new spanner db admin service config #1956
Conversation
PiperOrigin-RevId: 462086058 Source-Link: googleapis/googleapis@4f072bf Source-Link: https://github.com/googleapis/googleapis-gen/commit/06f699da66f7a07b9541e57a7d03863b4df4971c Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDZmNjk5ZGE2NmY3YTA3Yjk1NDFlNTdhN2QwMzg2M2I0ZGY0OTcxYyJ9
chore: remove old spanner db admin service config PiperOrigin-RevId: 463110616 Source-Link: googleapis/googleapis@0f38696 Source-Link: https://github.com/googleapis/googleapis-gen/commit/b048ca647e11fc92d5bcf0bec1881d25f321dea9 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjA0OGNhNjQ3ZTExZmM5MmQ1YmNmMGJlYzE4ODFkMjVmMzIxZGVhOSJ9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@rahul2393 @asthamohta : can one of you review this also reiview this around Session roles etc? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, there will be extra changes needed for databaseRole which I will pull in this PR from main once this one is merged
chore: remove old spanner db admin service config
PiperOrigin-RevId: 463110616
Source-Link: googleapis/googleapis@0f38696
Source-Link: https://github.com/googleapis/googleapis-gen/commit/b048ca647e11fc92d5bcf0bec1881d25f321dea9
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjA0OGNhNjQ3ZTExZmM5MmQ1YmNmMGJlYzE4ODFkMjVmMzIxZGVhOSJ9
feat: Add ListDatabaseRoles API to support role based access control
PiperOrigin-RevId: 462086058
Source-Link: googleapis/googleapis@4f072bf
Source-Link: https://github.com/googleapis/googleapis-gen/commit/06f699da66f7a07b9541e57a7d03863b4df4971c
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDZmNjk5ZGE2NmY3YTA3Yjk1NDFlNTdhN2QwMzg2M2I0ZGY0OTcxYyJ9