Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Error Details Improvement #1929

Merged
merged 6 commits into from
Jul 5, 2022
Merged

feat: Error Details Improvement #1929

merged 6 commits into from
Jul 5, 2022

Conversation

gauravpurohit06
Copy link
Contributor

Adding following public methods under SpannerException to provide more info related to errors.
-getReason()
-getDomain()
-getMetaData
-getErrorDetails()

@gauravpurohit06
1) While wrapping API exception under SpannerException, using actual …
6275b2f 
…exception not it's cause.

2) Added public methods under SpannerException to provide more info related to errors.
@gauravpurohit06 gauravpurohit06 requested a review from a team as a code owner June 28, 2022 08:56
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Jun 28, 2022 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: spanner Issues related to the googleapis/java-spanner API. labels Jun 28, 2022
@gauravpurohit06 gauravpurohit06 requested a review from blakeli0 June 28, 2022 10:26
@blakeli0 blakeli0 changed the title Error Details Improvement feat: Error Details Improvement Jun 28, 2022
@blakeli0
Copy link
Contributor

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot https://conventionalcommits.org/

@gauravpurohit06 Please make sure the commit message and PR title follow the conventional commits in the future. In this case, I just renamed the title to feat: Error Details Improvement. Once this PR is ready, before you squash and merge, please make sure the squashed commit message is also feat: Error Details Improvement, we have a few automation bots rely on this convention.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Jun 30, 2022
@gauravpurohit06
reactor: Modify SpannerException and derived classes constructor to a…
5fe21d0 
…dd support for APIException, and overloading method in SpannerExceptionFactory to add support for new parameter.
@ansh0l ansh0l added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 4, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 4, 2022
@gauravpurohit06 gauravpurohit06 requested a review from a team as a code owner July 4, 2022 17:20
@gauravpurohit06 gauravpurohit06 merged commit c8a2184 into googleapis:main Jul 5, 2022
@release-please release-please bot mentioned this pull request Jul 5, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 14, 2022
@release-please
chore(main): release 6.26.0 (#1935)
6ea1e2e 
🤖 I have created a release *beep* *boop*
---


## [6.26.0](v6.25.7...v6.26.0) (2022-07-13)


### Features

* Adding two new fields for Instance create_time and update_time ([#1908](#1908)) ([00b3817](00b3817))
* changes to support data, timestamp and arrays in IT tests ([#1840](#1840)) ([c667653](c667653))
* Error Details Improvement ([c8a2184](c8a2184))
* Error Details Improvement ([#1929](#1929)) ([c8a2184](c8a2184))


### Bug Fixes

* enable longpaths support for windows test ([#1485](#1485)) ([#1946](#1946)) ([fd0b845](fd0b845))


### Dependencies

* update dependency com.google.cloud:google-cloud-trace to v2.3.0 ([#1934](#1934)) ([2813eb2](2813eb2))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansh0l ansh0l ansh0l approved these changes

@olavloite olavloite olavloite approved these changes

@blakeli0 blakeli0 Awaiting requested review from blakeli0

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gauravpurohit06 @blakeli0 @olavloite @ansh0l