-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: changes to support data, timestamp and arrays in IT tests #1840
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, with a couple of minor questions.
@@ -771,7 +767,7 @@ public void bindNumericArray_doesNotPreservePrecision() { | |||
|
|||
Struct row = | |||
execute( | |||
Statement.newBuilder("SELECT @v").bind("v").toNumericArray(asList(b1, b2, null)), | |||
Statement.newBuilder(selectValueQuery).bind("p1").toNumericArray(asList(b1, b2, null)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test case seem to be disabled for PostgreSQL still. Is that intentional?
The same also seems to be the case for other numeric array tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missed those, adding it
@@ -429,6 +522,59 @@ public void testReadNullValuesInArrays() { | |||
} | |||
} | |||
|
|||
@Test | |||
public void testReadNullValuesInArraysPostgreSQL() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need separate tests for GoogleSQL and PostgreSQL in this case? They seem to be equal. Or am I missing something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
structs and json are not supported and column names are different as PG requires explicit quotes for case
@@ -615,9 +793,16 @@ public void testReadFloat64LiteralsGoogleStandardSQL() { | |||
public void testReadFloat64LiteralsPostgreSQL() { | |||
Assume.assumeTrue(dialect.dialect == Dialect.POSTGRESQL); | |||
try (ResultSet resultSet = | |||
databaseClient.singleUse().executeQuery(Statement.of("SELECT 10.0 AS float64"))) { | |||
databaseClient |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this need a separate test case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
🤖 I have created a release *beep* *boop* --- ## [6.26.0](v6.25.7...v6.26.0) (2022-07-13) ### Features * Adding two new fields for Instance create_time and update_time ([#1908](#1908)) ([00b3817](00b3817)) * changes to support data, timestamp and arrays in IT tests ([#1840](#1840)) ([c667653](c667653)) * Error Details Improvement ([c8a2184](c8a2184)) * Error Details Improvement ([#1929](#1929)) ([c8a2184](c8a2184)) ### Bug Fixes * enable longpaths support for windows test ([#1485](#1485)) ([#1946](#1946)) ([fd0b845](fd0b845)) ### Dependencies * update dependency com.google.cloud:google-cloud-trace to v2.3.0 ([#1934](#1934)) ([2813eb2](2813eb2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
No description provided.