Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support PG show transaction isolation level #1777

Merged
merged 2 commits into from
Mar 24, 2022

Conversation

olavloite
Copy link
Collaborator

Adds support for the PostgreSQL statement SHOW TRANSACTION ISOLATION
LEVEL. This statement is used by the PG JDBC driver to get the isolation
level of a connection. The statement will always return the static
string 'serializable', as that is the only isolation level Spangres
supports.

Adds support for the PostgreSQL statement SHOW TRANSACTION ISOLATION
LEVEL. This statement is used by the PG JDBC driver to get the isolation
level of a connection. The statement will always return the static
string 'serializable', as that is the only isolation level Spangres
supports.
@olavloite olavloite requested review from a team as code owners March 23, 2022 15:15
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Mar 23, 2022
@olavloite
Copy link
Collaborator Author

@ansh0l Do you have any idea why so many of the checks seem to be hanging?

@elefeint
Copy link
Contributor

fwiw, github had issues yesterday around 10am EST. Try restarting the actions manually.

Copy link
Contributor

@ansh0l ansh0l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Bulk of LOC is in the .sql file - where the new file looks largely good

@olavloite olavloite merged commit 111f74c into main Mar 24, 2022
@olavloite olavloite deleted the pg-show-isolation-level branch March 24, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants