-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(sample): relocate native image sample from old repo #1758
Conversation
Warning: This pull request is touching the following templated files:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Minor nit: I think since the parent folder is named samples
, we should call this one as native-image
instead of native-image-sample
…er into move-native-sample
Thank you @ansh0l! I've renamed this to |
Closing since native image changes have been released with #1878 |
Rerunning because |
All checks are now green. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At a quick glance, looks alright. Please take a full review with @rajatbhatta
<dependency> | ||
<groupId>com.google.cloud</groupId> | ||
<artifactId>libraries-bom</artifactId> | ||
<version>25.2.0</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QQ> AFAIK, currently, we get automated PRs for cloud bom version bumps. Would now there be 2 such PRs (one for regular samples/pom.xml, another for samples/native-image/pom.xml), or would both end up coming into 1 PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would all be updated in a single PR. Here is an example: googleapis/java-pubsub#1132
Co-authored-by: Rajat Bhatta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
The requested changes have been addressed so modifying this to a request comment after receiving an approval from @rajatbhatta
Thank you both for the review! |
🤖 I have created a release *beep* *boop* --- ## [6.25.6](v6.25.5...v6.25.6) (2022-06-22) ### Bug Fixes * PostgreSQL parser should not treat \ as an escape char ([#1921](#1921)) ([260bbe3](260bbe3)), closes [#1920](#1920) ### Documentation * **sample:** relocate native image sample from old repo ([#1758](#1758)) ([ef187f4](ef187f4)) ### Dependencies * update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.11 ([#1907](#1907)) ([01f8a07](01f8a07)) * update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.12 ([#1918](#1918)) ([be8b50b](be8b50b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Relocating Spanner sample from GoogleCloudPlatform/native-image-support-java.
This PR also adds an integration test that can be run as a native image.
Calling
mvn package -Pnative -DskipTests
builds the native image for the application and callingmvn test -Pnative
runs the test as a native image.For more information: https://graalvm.github.io/native-build-tools/latest/maven-plugin.html#configuration.
cc @ansh0l @meltsufin