-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allows for getting json columns using getValue #1699
Conversation
Allows for getting JSON values using resultSet.getValue().
Overrides the getString method in json values to allow for getString and getStringArray on json values.
|
||
private void assertThrowsWithMessage(Supplier<?> supplier, String message) { | ||
try { | ||
supplier.get(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I think you could also just use assertThrows(...)
for this instead of a try-catch-block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we can, because we match partially on the message of the exception
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITResultSetGetValue.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITResultSetGetValue.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Knut Olav Løite <[email protected]>
Co-authored-by: Knut Olav Løite <[email protected]>
@@ -56,13 +56,13 @@ implementation 'com.google.cloud:google-cloud-spanner' | |||
If you are using Gradle without BOM, add this to your dependencies | |||
|
|||
```Groovy | |||
implementation 'com.google.cloud:google-cloud-spanner:6.19.0' | |||
implementation 'com.google.cloud:google-cloud-spanner:6.19.1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This is a change from owlbot)
``` | ||
|
||
If you are using SBT, add this to your dependencies | ||
|
||
```Scala | ||
libraryDependencies += "com.google.cloud" % "google-cloud-spanner" % "6.19.0" | ||
libraryDependencies += "com.google.cloud" % "google-cloud-spanner" % "6.19.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This is a change from owlbot)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Allows for getting JSON values using resultSet.getValue(). This was not possible before, because a mapping was missing.
Overrides the getString method in json values to allow for getString and getStringArray on json values.