fix: annotating some fields as REQUIRED #1695
Conversation
![gcf-owl-bot[bot]](https://avatars.githubusercontent.com/in/99011?s=60&v=4){kind=small}
These fields were actually always required by the backend, so annotation just documents status quo. I believe this change will not require major version bump for any language. PiperOrigin-RevId: 429093810 Source-Link: googleapis/googleapis@dc04c1c Source-Link: https://github.com/googleapis/googleapis-gen/commit/0e23469bea2f397f2b783c5a25e64452f86be6bc Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGUyMzQ2OWJlYTJmMzk3ZjJiNzgzYzVhMjVlNjQ0NTJmODZiZTZiYyJ9
product-auto-label
bot
added
the
api: spanner
trusted-contributions-gcf
bot
added
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
trusted-contributions-gcf
bot
added
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
thiagotnunes
added
the
do not merge
|
Is this a breaking change? If so, it would require us to do a major release, which is not ideal @ansh0l could you follow up? |
|
Sure @thiagotnunes, will followup |
suztomo
added
the
automerge
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
gcf-merge-on-green
bot
removed
the
automerge
|
@ansh0l cl/429093810 has description about the change and it says the author doesn't expect breaking change in customers' code. If this is the case, there's no need to bump the major version. The automation bot reads "!" in "feat!" for breaking changes. If this is not a breaking change, then remove "!" from the PR title. When merging, ensure the squashed commit to the main branch doesn't have "!" either. |
|
Will be parking this PR for some more time before other major PRs are shipped for java and jdbc. |
Neenu1995
changed the title
|
@ansh0l afaik we can merge now, because we removed the |
|
@thiagotnunes I think we are good. I was busy with Spangres merges yesterday, so kept it waiting for another day. |
ansh0l
removed
the
do not merge
* chore(java): update gcp-releasetool and cryptography in java requirements file Source-Link: googleapis/synthtool@74d0956 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:142286d973c7b6d58186070f203b50058a20a7d7b42147996db24921a18da1b0
…s#1695) (googleapis#1043) * chore(java): update gcp-releasetool and cryptography in java requirements file Source-Link: https://togithub.com/googleapis/synthtool/commit/74d0956884c1bb9dc901b52de35ca2bca025a74e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:142286d973c7b6d58186070f203b50058a20a7d7b42147996db24921a18da1b0
These fields were actually always required by the backend, so annotation just documents status quo. I believe this change will not require major version bump for any language.
PiperOrigin-RevId: 429093810
Source-Link: googleapis/googleapis@dc04c1c
Source-Link: https://github.com/googleapis/googleapis-gen/commit/0e23469bea2f397f2b783c5a25e64452f86be6bc
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGUyMzQ2OWJlYTJmMzk3ZjJiNzgzYzVhMjVlNjQ0NTJmODZiZTZiYyJ9