Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: increase integration tests timeout #1440

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

thiagotnunes
Copy link
Contributor

Integration tests are timing out at the 54 minute mark. It correlates well with the current forkedProcess timeout set for failsafe plugin which is 3000 seconds (50 minutes).

Here we increase it to 6000 seconds to see if the issue is resolved.

@thiagotnunes thiagotnunes requested review from a team as code owners September 23, 2021 09:34
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 23, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Sep 23, 2021
Copy link
Collaborator

@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any idea why it has started to exceed the previous timeout? I don't think there were any new integration tests that were added recently that would take a long time. Or am I missing something?

@thiagotnunes
Copy link
Contributor Author

Not sure, it seems that some operations were a bit slower than usual in our development instance, especially instance admin operations. We will keep an eye out.

@thiagotnunes thiagotnunes merged commit 03a82fd into master Sep 23, 2021
@thiagotnunes thiagotnunes deleted the increases-integration-test-timeout branch September 23, 2021 10:52
KiranmayiB pushed a commit to KiranmayiB/java-spanner that referenced this pull request Sep 24, 2021
gcf-owl-bot bot added a commit that referenced this pull request May 19, 2022
Source-Link: googleapis/synthtool@505ce5a
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:2567a120ce90fadb6201999b87d649d9f67459de28815ad239bce9ebfaa18a74
gcf-merge-on-green bot pushed a commit that referenced this pull request May 19, 2022
…1881)

Source-Link: googleapis/synthtool@505ce5a
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:2567a120ce90fadb6201999b87d649d9f67459de28815ad239bce9ebfaa18a74
rajatbhatta pushed a commit to rajatbhatta/java-spanner that referenced this pull request Nov 17, 2022
…is#1440) (googleapis#875)

Source-Link: googleapis/synthtool@505ce5a
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:2567a120ce90fadb6201999b87d649d9f67459de28815ad239bce9ebfaa18a74

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
rajatbhatta pushed a commit to rajatbhatta/java-spanner that referenced this pull request Nov 17, 2022
🤖 I have created a release *beep* *boop*
---


## [2.7.0](googleapis/java-spanner-jdbc@v2.6.4...v2.7.0) (2022-05-24)


### Features

* add build scripts for native image testing in Java 17 ([googleapis#1440](googleapis/java-spanner-jdbc#1440)) ([googleapis#875](googleapis/java-spanner-jdbc#875)) ([600e401](googleapis/java-spanner-jdbc@600e401))


### Dependencies

* bump Spanner to 6.23.3 ([googleapis#862](googleapis/java-spanner-jdbc#862)) ([b7b8efa](googleapis/java-spanner-jdbc@b7b8efa)), closes [googleapis#788](googleapis/java-spanner-jdbc#788)
* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.12.0 ([googleapis#874](googleapis/java-spanner-jdbc#874)) ([d403f54](googleapis/java-spanner-jdbc@d403f54))
* update opencensus.version to v0.31.1 ([googleapis#865](googleapis/java-spanner-jdbc#865)) ([61ba9be](googleapis/java-spanner-jdbc@61ba9be))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants