-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: adding pubsub emulator example #1602
docs: adding pubsub emulator example #1602
Conversation
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
…rimangal/java-pubsub into movingSampleEmulatorExample
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please get approval from Tianzi as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you. i'd recommend adding a test as well. feel free to create a new issue to track that work. you can use Cloud Build with a public container image with Pub/Sub emulator preinstalled to write the test.
cloudbuild.yaml
example:
steps:
- name: gcr.io/google.com/cloudsdktool/cloud-sdk:433.0.1-emulators
entrypoint: 'gcloud'
args: ['beta', 'emulators', 'pubsub', 'start', '--project=abc', '--host-port=0.0.0.0:8085']
env:
- 'PUBSUB_EMULATOR_HOST=localhost:8085'
Also, don't forget to update docs or ping Moi Borah to update docs. :-)
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.