Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix a test that is flaky on requestLimit. The used project is returning INTERNAL by design. #2340

Merged
merged 1 commit into from
Nov 30, 2023
Merged

fix: fix a test that is flaky on requestLimit. The used project is returning INTERNAL by design. #2340

merged 1 commit into from
Nov 30, 2023

Conversation

yirutang
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@yirutang yirutang requested a review from a team as a code owner November 30, 2023 19:31
@yirutang yirutang requested a review from shollyman November 30, 2023 19:31
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. labels Nov 30, 2023
@yirutang yirutang added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 30, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 30, 2023
@yirutang yirutang merged commit cb6e2c9 into googleapis:main Nov 30, 2023
16 of 17 checks passed
@release-please release-please bot mentioned this pull request Dec 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neenu1995 Neenu1995 Neenu1995 approved these changes

@shollyman shollyman Awaiting requested review from shollyman shollyman is a code owner automatically assigned from googleapis/api-bigquery

Assignees
No one assigned
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yirutang @Neenu1995