fix: Reduce timeout of waiting in queue from 15 minutes to 5 minutes and rephrase the log a bit #2084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xs
GaoleMeng
changed the title
yirutang
reviewed
Apr 22, 2023
...oud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/ConnectionWorker.java
Outdated
Show resolved
Hide resolved
…eue. Since in write api server side we have total timeout of 2 minutes, it does not make sense to wait 15 minutes to determine whether we have met dead connection, let's reduce the timeout here
GaoleMeng
changed the title
yirutang
approved these changes
Apr 22, 2023
GaoleMeng
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Apr 26, 2023
🤖 I have created a release *beep* *boop* --- ## [2.36.0](https://togithub.com/googleapis/java-bigquerystorage/compare/v2.35.0...v2.36.0) (2023-04-26) ### Features * Adding ExecutorProvider support while creating BigQueryReadClient ([#2072](https://togithub.com/googleapis/java-bigquerystorage/issues/2072)) ([9221e18](https://togithub.com/googleapis/java-bigquerystorage/commit/9221e1896f7af6c2dd23e92f6ea13d86c3368600)) ### Bug Fixes * Reduce timeout of waiting in queue from 15 minutes to 5 minutes and rephrase the log a bit ([#2084](https://togithub.com/googleapis/java-bigquerystorage/issues/2084)) ([fe25f38](https://togithub.com/googleapis/java-bigquerystorage/commit/fe25f38215ffaacd2cbe4af74c0de9ea7c053d91)) ### Dependencies * Update dependency com.google.cloud:google-cloud-bigquery to v2.24.5 ([#2081](https://togithub.com/googleapis/java-bigquerystorage/issues/2081)) ([362568d](https://togithub.com/googleapis/java-bigquerystorage/commit/362568d4d8e1cf5e1e2a1bbfe3513d440f9fb99f)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.8.0 ([#2087](https://togithub.com/googleapis/java-bigquerystorage/issues/2087)) ([1f79a96](https://togithub.com/googleapis/java-bigquerystorage/commit/1f79a9691ebb5f22077534fb7d266df830cb7ec2)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since write api server side per request timeout is 2 minutes, it does not make sense to wait 15 minutes to determine whether a connection has been dead, reducing it to 3 minutes
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.