Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JsonStreamWriter.Builder#setEnableConnectionPool does not obey argument passed #2083

Closed
bastewart opened this issue Apr 21, 2023 · 3 comments
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@bastewart
Copy link

Code example

setEnableConnectionPool does not obey the argument passed, instead however it is called connection pooling is enabled.

You can see this in the current master branch below (introduced - presumably by mistake! - in #2048):

public Builder setEnableConnectionPool(boolean enableConnectionPool) {
this.schemaAwareStreamWriterBuilder.setEnableConnectionPool(true);
return this;
}

Sorry, I have never contributed to this repo otherwise I'd just open a PR with a fix myself!

@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. label Apr 21, 2023
@Neenu1995
Copy link
Contributor

Thanks for opening the issue @bastewart.
Opened PR to fix it.

Feel free to open a PR in the future, contributors are always welcome.

@Neenu1995 Neenu1995 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels May 1, 2023
@bastewart
Copy link
Author

Thank you! 🙏

@bastewart
Copy link
Author

Fixed in #2096. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

2 participants