Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding ExecutorProvider support while creating BigQueryReadClient #2072

Merged
merged 3 commits into from
Apr 14, 2023

Conversation

suryasoma
Copy link
Contributor

@suryasoma suryasoma commented Mar 30, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)
Fixes #2071 ☕️

If you write sample code, please follow the samples format.

@suryasoma suryasoma requested a review from a team as a code owner March 30, 2023 20:46
@suryasoma suryasoma requested a review from farhan0102 March 30, 2023 20:46
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. labels Mar 30, 2023
@kmjung
Copy link
Contributor

kmjung commented Apr 4, 2023

R: @Neenu1995

@farhan0102 farhan0102 added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 4, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 4, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 4, 2023
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner April 4, 2023 18:17
@suryasoma suryasoma changed the title Adding ExecutorProvider support while creating BigQueryReadClient feat: Adding ExecutorProvider support while creating BigQueryReadClient Apr 6, 2023
@Neenu1995 Neenu1995 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 13, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 13, 2023
@suryasoma suryasoma force-pushed the bqReadClientWithExecutorProvider branch from 452f0a2 to 316dbc8 Compare April 14, 2023 17:41
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xs Pull request size is extra small. labels Apr 14, 2023
@Neenu1995 Neenu1995 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 14, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 14, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 14, 2023
@Neenu1995 Neenu1995 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 14, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 14, 2023
@Neenu1995 Neenu1995 merged commit 9221e18 into googleapis:main Apr 14, 2023
gcf-merge-on-green bot pushed a commit that referenced this pull request Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BigQueryReadClient cannot be created with custom ExecutorProvider
6 participants