feat: throw error when using connection pool for explicit stream #1903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prerequisite for multiplexing client
new stream name as a switch of destinationt
also fixed a tiny bug inside fake bigquery write impl for getting thre response from offset
possible the proto schema does not contain this field
create/tear down too much threads if lots of retries happens
product-auto-label
bot
added
size: s
yirutang
reviewed
Dec 2, 2022
...e-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/StreamWriter.java
Outdated
Show resolved
Hide resolved
yirutang
reviewed
Dec 2, 2022
| private static final String TEST_STREAM_1 = "projects/p/datasets/d1/tables/t1/streams/s1"; | ||
| private static final String TEST_STREAM_2 = "projects/p/datasets/d2/tables/t2/streams/s2"; | ||
| private static final String TEST_STREAM_1 = "projects/p/datasets/d1/tables/t1/streams/_default"; | ||
| private static final String TEST_STREAM_2 = "projects/p/datasets/d2/tables/t2/streams/_default"; |
There was a problem hiding this comment.
Add a test to cover that name.
product-auto-label
bot
added
size: m
yirutang
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
yirutang
approved these changes
Dec 2, 2022
yirutang
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Dec 12, 2022
🤖 I have created a release *beep* *boop* --- ## [2.27.0](https://togithub.com/googleapis/java-bigquerystorage/compare/v2.26.0...v2.27.0) (2022-12-12) ### Features * Change one thread per retry to use a thread pool ([#1898](https://togithub.com/googleapis/java-bigquerystorage/issues/1898)) ([44a4e4d](https://togithub.com/googleapis/java-bigquerystorage/commit/44a4e4d8c70bf910f96d2d2c181d1f23b70f3e52)) * Throw error when using connection pool for explicit stream ([#1903](https://togithub.com/googleapis/java-bigquerystorage/issues/1903)) ([bd89556](https://togithub.com/googleapis/java-bigquerystorage/commit/bd895567fe33735294065d7043d845f14f33f8a8)) ### Bug Fixes * Add back the accidentally removed background executor provider ([#1899](https://togithub.com/googleapis/java-bigquerystorage/issues/1899)) ([065cc4f](https://togithub.com/googleapis/java-bigquerystorage/commit/065cc4f35ad5e5cdc393e01adbea881c6e92dcab)) * Update JsonStreamWriterBuilder comment and update sample to use the latest schema retrieval support ([#1902](https://togithub.com/googleapis/java-bigquerystorage/issues/1902)) ([2a46ec3](https://togithub.com/googleapis/java-bigquerystorage/commit/2a46ec3df419bbeba6a2e60b2b621dc60f31eab1)) ### Dependencies * Update arrow.version to v10.0.1 ([#1894](https://togithub.com/googleapis/java-bigquerystorage/issues/1894)) ([8e90767](https://togithub.com/googleapis/java-bigquerystorage/commit/8e907677bae0c48e8c64be5cbab8fb203645f4ef)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.1.0 ([#1905](https://togithub.com/googleapis/java-bigquerystorage/issues/1905)) ([767be03](https://togithub.com/googleapis/java-bigquerystorage/commit/767be035defbcc5b77f1276bb1a2983b6a7423bd)) * Update dependency org.apache.arrow:arrow-memory-netty to v10.0.1 ([#1895](https://togithub.com/googleapis/java-bigquerystorage/issues/1895)) ([8b079cc](https://togithub.com/googleapis/java-bigquerystorage/commit/8b079cc47ca914756bd73dda98bd15393754ebb1)) * Update dependency org.apache.arrow:arrow-vector to v10.0.1 ([#1896](https://togithub.com/googleapis/java-bigquerystorage/issues/1896)) ([087ac6e](https://togithub.com/googleapis/java-bigquerystorage/commit/087ac6e7ad813dc248e9029f91c454299a87b2b3)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.