Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix windows build failure by using nanoSeconds instead of Instant for better accuracy. #1887

Merged
merged 48 commits into from
Nov 16, 2022

Conversation

GaoleMeng
Copy link
Contributor

@GaoleMeng GaoleMeng commented Nov 16, 2022

nanoSeconds can provide us with higher resolution in nano second level. In this way we don't need any hacky sleep() inside unit testing, and it avoids the flackiness introduced by time resolution problem in WIndows

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

GaoleMeng and others added 30 commits September 13, 2022 01:58
also fixed a tiny bug inside fake bigquery write impl for getting thre
response from offset
possible the proto schema does not contain this field
@GaoleMeng GaoleMeng requested review from a team and prash-mi November 16, 2022 19:49
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Nov 16, 2022
@GaoleMeng GaoleMeng changed the title [debug only]: fixing windows test feat: fix windows build failure by using nanoSeconds instead of Instant for better accuracy. Nov 16, 2022
@Neenu1995 Neenu1995 added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 16, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 16, 2022
@GaoleMeng GaoleMeng merged commit e5cd7df into googleapis:main Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants