-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fix windows build failure by using nanoSeconds instead of Instant for better accuracy. #1887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prerequisite for multiplexing client
new stream name as a switch of destinationt
also fixed a tiny bug inside fake bigquery write impl for getting thre response from offset
possible the proto schema does not contain this field
possible the proto schema does not contain this field
…te for the same stream name can be notified
product-auto-label
bot
added
size: xs
Pull request size is extra small.
api: bigquerystorage
Issues related to the googleapis/java-bigquerystorage API.
size: s
Pull request size is small.
and removed
size: xs
Pull request size is extra small.
labels
Nov 16, 2022
yirutang
approved these changes
Nov 16, 2022
GaoleMeng
changed the title
[debug only]: fixing windows test
feat: fix windows build failure by using nanoSeconds instead of Instant for better accuracy.
Nov 16, 2022
Neenu1995
added
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Nov 16, 2022
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: bigquerystorage
Issues related to the googleapis/java-bigquerystorage API.
size: s
Pull request size is small.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nanoSeconds can provide us with higher resolution in nano second level. In this way we don't need any hacky sleep() inside unit testing, and it avoids the flackiness introduced by time resolution problem in WIndows
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.