Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix window build bug caused by Instant resolution. #1884

Merged
merged 45 commits into from
Nov 16, 2022
Merged

fix: Fix window build bug caused by Instant resolution. #1884

merged 45 commits into from
Nov 16, 2022

Conversation

GaoleMeng
Copy link
Contributor

@GaoleMeng GaoleMeng commented Nov 15, 2022

The bug happened because Windows Instant resolution is about 10ms level:
https://stackoverflow.com/a/20689231
We decided to change test directly, as in reality this bug can seldom happened due to the updated schema is required to happen after a server/client communication, which is at 100ms level

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

GaoleMeng and others added 30 commits September 13, 2022 01:58
also fixed a tiny bug inside fake bigquery write impl for getting thre
response from offset
possible the proto schema does not contain this field
@GaoleMeng GaoleMeng requested review from a team and alvarowolfx November 15, 2022 19:59
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. labels Nov 15, 2022
@GaoleMeng GaoleMeng changed the title [debug only] Trying to debug windows build failure Fix window build bug caused by Instant resolution. Nov 15, 2022
@GaoleMeng GaoleMeng changed the title Fix window build bug caused by Instant resolution. fix: Fix window build bug caused by Instant resolution. Nov 15, 2022
yirutang
yirutang previously approved these changes Nov 15, 2022
@GaoleMeng GaoleMeng requested a review from Neenu1995 November 15, 2022 21:01
@Neenu1995 Neenu1995 added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 15, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 15, 2022
@yirutang yirutang self-requested a review November 15, 2022 21:21
@yirutang yirutang dismissed their stale review November 15, 2022 21:22

discussing more.

@product-auto-label product-auto-label bot added size: s Pull request size is small. size: xs Pull request size is extra small. and removed size: xs Pull request size is extra small. size: s Pull request size is small. labels Nov 15, 2022
@GaoleMeng GaoleMeng added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 15, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 15, 2022
@GaoleMeng GaoleMeng merged commit 2332dc1 into googleapis:main Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants