feat(datestrings): Allow string dates, closes #1765 #1916
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xs
dark0dave
changed the title
|
@ismailsimsek will this do? |
|
@dark0dave it looks good to me +1 |
Signed-off-by: dark0dave <[email protected]>
|
Should be ready now. Apologies, its the holiday season. |
|
@ismailsimsek let me know if you need any other types for dates to be added. Longs/shorts/floats etc. |
|
@aribray this is ready for review please :), thank you. |
Neenu1995
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
kokoro:force-run
yirutang
reviewed
Apr 3, 2023
| @@ -710,6 +716,12 @@ private static void fillRepeatedField( | |||
| } | |||
| break; | |||
| case STRING: | |||
| if (fieldSchema != null && fieldSchema.getType() == TableFieldSchema.Type.DATE) { | |||
| if (val instanceof String) { | |||
| protoMsg.setField(fieldDescriptor, (String) val); | |||
| TestDate.newBuilder() | ||
| .setTestString(18935) | ||
| .setTestLong(18935) | ||
| .setTestIsoString("1999-01-01") |
There was a problem hiding this comment.
Add a test for repeated field.
|
is there any update on this feature? |
Waiting for the owner to address review feedbacks? If I didn't hear him for a week, I will submit a patched PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1765
Signed-off-by: dark0dave [email protected]