Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: string to correct type (INT32, INT64, FLOAT, BOOLEAN) #1588

Merged
merged 1 commit into from
Mar 29, 2022
Merged

feat: string to correct type (INT32, INT64, FLOAT, BOOLEAN) #1588

merged 1 commit into from
Mar 29, 2022

Conversation

dark0dave
Copy link
Contributor

@dark0dave dark0dave commented Mar 26, 2022

Closes #1586, this allows users to send strings of numerics to the api and have them case properly into the correct numeric type.

@dark0dave dark0dave requested review from a team and steffnay March 26, 2022 12:59
@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. label Mar 26, 2022
@dark0dave dark0dave changed the title Feature/numerics feat: String to Numeric Mar 26, 2022
@dark0dave dark0dave changed the title feat: String to Numeric feat: string to numeric Mar 26, 2022
@dark0dave
Copy link
Contributor Author

dark0dave commented Mar 26, 2022

with data [{{"i":"-1"},{"f":"-10.0"}}...]
image

@dark0dave dark0dave changed the title feat: string to numeric feat: string to correct type (INT32, INT64, FLOAT, BOOLEAN) Mar 28, 2022
Copy link
Contributor

@stephaniewang526 stephaniewang526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a unit test for these changes?

@dark0dave dark0dave requested a review from a team as a code owner March 28, 2022 19:29
@dark0dave
Copy link
Contributor Author

@stephaniewang526 tests added.

@dark0dave
Copy link
Contributor Author

@stephaniewang526 let me know if anything else is needed.

@stephaniewang526 stephaniewang526 added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 29, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 29, 2022
@stephaniewang526 stephaniewang526 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 29, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 29, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 29, 2022
@stephaniewang526 stephaniewang526 merged commit 085768b into googleapis:main Mar 29, 2022
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 30, 2022
🤖 I have created a release *beep* *boop*
---


### [2.11.1](v2.11.0...v2.11.1) (2022-03-29)


### Bug Fixes

* Numerics cast from strings ([#1588](#1588)) ([085768b](085768b))


### Dependencies

* update dependency com.google.cloud:google-cloud-bigquery to v2.10.0 ([#1578](#1578)) ([adca54e](adca54e))
* update dependency com.google.cloud:google-cloud-bigquery to v2.10.1 ([#1583](#1583)) ([cc33d0e](cc33d0e))
* update dependency com.google.cloud:google-cloud-bigquery to v2.10.2 ([#1587](#1587)) ([d4ab7f6](d4ab7f6))
* update dependency com.google.cloud:google-cloud-bigquery to v2.10.3 ([#1591](#1591)) ([0c62c85](0c62c85))
* update dependency com.google.cloud:google-cloud-bigquery to v2.10.4 ([#1594](#1594)) ([05e9062](05e9062))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.9.0 ([#1593](#1593)) ([5234809](5234809))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
gcf-owl-bot bot added a commit that referenced this pull request Sep 26, 2022
…#1588)

* chore: pin versions of dependencies for compatibility with Python 3.6

* fix path of requirements file in synthtool
Source-Link: googleapis/synthtool@69cdb47
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6566dc8226f20993af18e5a4e7a2b1ba85a292b02dedb6a1634cf10e1b418fa5
shubhwip pushed a commit to shubhwip/java-bigquerystorage that referenced this pull request Oct 7, 2023
…googleapis#1588) (googleapis#996)

* chore: pin versions of dependencies for compatibility with Python 3.6

* fix path of requirements file in synthtool
Source-Link: googleapis/synthtool@69cdb47
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6566dc8226f20993af18e5a4e7a2b1ba85a292b02dedb6a1634cf10e1b418fa5

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parse String to Ints, Longs, Floats, Bools
4 participants