Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: temp workaround for omg/48020 #1521

Merged
merged 19 commits into from
Feb 8, 2022
Merged

feat: temp workaround for omg/48020 #1521

merged 19 commits into from
Feb 8, 2022

Conversation

yirutang
Copy link
Contributor

@yirutang yirutang commented Feb 8, 2022

This should only be used by customer who is affected by omg/48020 (connection stuck after 10MB) using JsonWriter directly, before fix finished rolling out on Friday 2/11. It can be enabled by calling JsonWriter.setReconnectOnStuck(true).

The write performance will be impacted by this change, but it can work around the stuckness.

@yirutang yirutang requested review from a team and steffnay February 8, 2022 16:14
@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. label Feb 8, 2022
@yirutang yirutang changed the title feat: temp workaround for omg/48020 DRAFT: feat: temp workaround for omg/48020 Feb 8, 2022
@yirutang yirutang changed the title DRAFT: feat: temp workaround for omg/48020 feat: temp workaround for omg/48020 Feb 8, 2022
@stephaniewang526 stephaniewang526 added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 8, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 8, 2022
@yirutang yirutang requested a review from a team as a code owner February 8, 2022 19:50
@stephaniewang526 stephaniewang526 added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 8, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 8, 2022
* @param reconnectOnStuck
* @return Builder
*/
public Builder setReconnectOnStuck(boolean reconnectOnStuck) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename this to something less pleasant so no one enables it by accident? For example if the omg numbers are public, can we embed that in the name of the method?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O yeah. how about ReconnectAfter10M?

@yirutang yirutang requested a review from gnanda February 8, 2022 21:52
@stephaniewang526 stephaniewang526 added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 8, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 8, 2022
@stephaniewang526 stephaniewang526 added owlbot:run Add this label to trigger the Owlbot post processor. automerge Merge the pull request once unit tests and other checks pass. labels Feb 8, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 8, 2022
@stephaniewang526 stephaniewang526 added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 8, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 8, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit ff28f65 into googleapis:main Feb 8, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 8, 2022
gcf-merge-on-green bot pushed a commit that referenced this pull request Feb 8, 2022
🤖 I have created a release *beep* *boop*
---


## [2.9.0](v2.8.4...v2.9.0) (2022-02-08)


### Features

* add a indicator of how much time a request is waiting for inflight limit ([#1514](#1514)) ([54874be](54874be))
* temp workaround for omg/48020 ([#1521](#1521)) ([ff28f65](ff28f65))


### Bug Fixes

* add a DATE type e2e test ([#1511](#1511)) ([5eaf38e](5eaf38e))


### Documentation

* **tutorials:** Add IT to JsonWriteDefaultStream tutorial ([#1522](#1522)) ([9fd7aca](9fd7aca))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants