Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

civil: Before and After methods for Time #5702

Closed
mohamadHarith opened this issue Feb 27, 2022 · 2 comments · Fixed by #5703
Closed

civil: Before and After methods for Time #5702

mohamadHarith opened this issue Feb 27, 2022 · 2 comments · Fixed by #5703
Assignees
@codyoss
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@mohamadHarith
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I am unable to check whether a time occurs before or after another time.

Describe the solution you'd like
A Before and After methods for Time.

Describe alternatives you've considered
I could convert the civil.Time to Golang's time.Time using civil.TimeOf and then do the comparison using the After and Before methods of time.Time but this is troublesome. It would be better if civil could provide these methods out of the box.
@mohamadHarith mohamadHarith added the triage me I really want to be triaged. label Feb 27, 2022
@mohamadHarith mohamadHarith mentioned this issue Feb 27, 2022
Merged
@codyoss codyoss added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triage me I really want to be triaged. labels Feb 28, 2022
@codyoss codyoss self-assigned this Feb 28, 2022
@codyoss
Copy link
Member

codyoss commented Feb 28, 2022

Thanks for the PR, I will take a look and get back to you.

@mohamadHarith
Copy link
Contributor Author

alright, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codyoss codyoss

Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(civil): before and after methods for Time mohamadHarith/google-cloud-go
2 participants
@codyoss @mohamadHarith