From 7785a60a1459b1a6cac0caabd2930f6f041e1ea3 Mon Sep 17 00:00:00 2001 From: Emmanuel T Odeke Date: Fri, 1 Nov 2024 06:52:25 -0700 Subject: [PATCH] spanner/request-id: some methods like Cleanup do not do retries automatically --- spanner/batch.go | 4 ---- 1 file changed, 4 deletions(-) diff --git a/spanner/batch.go b/spanner/batch.go index 9067a0618781..2c38d4a36d59 100644 --- a/spanner/batch.go +++ b/spanner/batch.go @@ -134,8 +134,6 @@ func (t *BatchReadOnlyTransaction) PartitionReadUsingIndexWithOptions(ctx contex } var md metadata.MD sh.updateLastUseTime() - // TODO: (@odeke-em) retrieve the requestID and increment the RPC number - // then send it along in every call per retry. resp, err = client.PartitionRead(contextWithOutgoingMetadata(ctx, sh.getMetadata(), t.disableRouteToLeader), &sppb.PartitionReadRequest{ Session: sid, Transaction: ts, @@ -286,8 +284,6 @@ func (t *BatchReadOnlyTransaction) Cleanup(ctx context.Context) { t.sh = nil sid, client := sh.getID(), sh.getClient() - // TODO: (@odeke-em) retrieve the requestID and increment the RPC number - // then send it along in every call per retry. var md metadata.MD err := client.DeleteSession(contextWithOutgoingMetadata(ctx, sh.getMetadata(), true), &sppb.DeleteSessionRequest{Name: sid}, gax.WithGRPCOptions(grpc.Header(&md)))