Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: IdTokenClient expiry_date check #1555

Merged
merged 2 commits into from
Jun 6, 2023

Conversation

AyushWalekar
Copy link
Contributor

@AyushWalekar AyushWalekar commented May 25, 2023

to respect eagerRefreshThresholdMillis of parent class OAuth2Client

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1554 🦕

to respect eagerRefreshThresholdMillis of parent class `OAuth2Client`
@AyushWalekar AyushWalekar requested review from a team as code owners May 25, 2023 06:49
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auth/IdTokenClient should respect eagerRefreshThresholdMillis while checking token expiry
4 participants