This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 107
feat: de-experiment google-c2p resolver #1896
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mohanli-ml Can you copy paste the error message? |
Error message:
|
Indeed testCancelOuterFutureAfterStart seems irrelevant. Retrying. From "downstream / graalvm (22.2.0, 11, orgpolicy) "
|
All checks have passed |
@mohanli-ml When we release this change, do we need to wait for any change in the backend? |
Kudos, SonarCloud Quality Gate passed! |
suztomo
approved these changes
Nov 23, 2022
Mohan told the backend works for both scheme. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change in grpc-java: https://github.com/grpc/grpc-java/blob/master/googleapis/src/main/java/io/grpc/googleapis/GoogleCloudToProdNameResolverProvider.java#L39.
@apolcyn