This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
feat: relocate GoogleJsonClientFeature from java-core to gax #1655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meltsufin
suggested changes
Apr 8, 2022
There was a problem hiding this comment.
Can it go into this repo instead: https://github.com/googleapis/google-api-java-client?
|
We'll run into the same problem as #1651. Unfortunately, the call to |
|
Oh it's that one with Java 7 issue! Right! |
meltsufin
approved these changes
Apr 8, 2022
|
SonarCloud Quality Gate failed. |
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Apr 14, 2022
🤖 I have created a release *beep* *boop* --- ## [2.16.0](v2.15.0...v2.16.0) (2022-04-14) ### Features * relocate ApiClientSubstitutions from java-core to gax ([#1651](#1651)) ([321103f](321103f)) * relocate GoogleJsonClientFeature from java-core to gax ([#1655](#1655)) ([6e75ec7](6e75ec7)) * relocate netty and gax substitutions from java-core ([#1650](#1650)) ([afd1917](afd1917)) * relocate Opencensus configurations from java-core to gax ([#1646](#1646)) ([b34ffb1](b34ffb1)) * relocate resource-config from java-core to gax ([#1656](#1656)) ([a9e5483](a9e5483)) ### Dependencies * google-common-protos 2.8.3 ([#1657](#1657)) ([24b9138](24b9138)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
suztomo
pushed a commit
to googleapis/sdk-platform-java
that referenced
this pull request
Dec 16, 2022
🤖 I have created a release *beep* *boop* --- ## [2.16.0](googleapis/gax-java@v2.15.0...v2.16.0) (2022-04-14) ### Features * relocate ApiClientSubstitutions from java-core to gax ([#1651](googleapis/gax-java#1651)) ([0d28727](googleapis/gax-java@0d28727)) * relocate GoogleJsonClientFeature from java-core to gax ([#1655](googleapis/gax-java#1655)) ([6f1ebe8](googleapis/gax-java@6f1ebe8)) * relocate netty and gax substitutions from java-core ([#1650](googleapis/gax-java#1650)) ([07a89cc](googleapis/gax-java@07a89cc)) * relocate Opencensus configurations from java-core to gax ([#1646](googleapis/gax-java#1646)) ([80e8b3f](googleapis/gax-java@80e8b3f)) * relocate resource-config from java-core to gax ([#1656](googleapis/gax-java#1656)) ([ec3f030](googleapis/gax-java@ec3f030)) ### Dependencies * google-common-protos 2.8.3 ([#1657](googleapis/gax-java#1657)) ([f9277bc](googleapis/gax-java@f9277bc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/googleapis/google-http-java-client still uses Java 7 as the compiler target which is not compatible with the Feature interface so moving this to gax for now. See: https://www.graalvm.org/release-notes/19_0/ . Tested this out locally with Storage and Pub/Sub.
TODO: