Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

fix: revert "feat: add api key support (#1436)" #1617

Merged
merged 2 commits into from
Jan 29, 2022
Merged

Conversation

arithmetic1728
Copy link
Contributor

@arithmetic1728 arithmetic1728 commented Jan 28, 2022

GOOGLE_API_KEY is used and may be set by other products, so throwing exception when both GOOGLE_API_KEY and GOOGLE_APPLICATION_CREDENTIALS are set may crash gax-java. Reverting the api key support until we figure out the solution for adding it back.

@arithmetic1728 arithmetic1728 requested review from a team as code owners January 28, 2022 23:52
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

71.4% 71.4% Coverage
0.0% 0.0% Duplication

@arithmetic1728 arithmetic1728 merged commit 47f98b8 into main Jan 29, 2022
@arithmetic1728 arithmetic1728 deleted the revert_apikey branch January 29, 2022 01:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants