Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add staticcheck as a presubmit check #1529

Open
julieqiu opened this issue Aug 14, 2024 · 0 comments
Open

add staticcheck as a presubmit check #1529

julieqiu opened this issue Aug 14, 2024 · 0 comments
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. process process/chore oriented work

Comments

@julieqiu
Copy link
Member

julieqiu commented Aug 14, 2024

staticcheck is a common linter for Go projects. We should consider adding it as a presubmit check for PRs to catch things like #1527, #1526, and #1525

We should consider adding it as a presubmit check for this repo. See googleapis/gapic-generator-go#1404 for a similar feature.

As of [f888517](https://github.com/googleapis/gapic-showcase/commit/f8885173d81acd923e10b113e5f55ed18f58bf31), running staticcheck returns these errors:

client/compliance_client.go:71:3: internaloption.WithDefaultEndpoint is deprecated: WithDefaultEndpoint does not support setting the universe domain. Use WithDefaultEndpointTemplate and WithDefaultUniverseDomain to compose the default endpoint instead.  (SA1019)
client/compliance_client.go:431:3: internaloption.WithDefaultEndpoint is deprecated: WithDefaultEndpoint does not support setting the universe domain. Use WithDefaultEndpointTemplate and WithDefaultUniverseDomain to compose the default endpoint instead.  (SA1019)
client/echo_client.go:81:3: internaloption.WithDefaultEndpoint is deprecated: WithDefaultEndpoint does not support setting the universe domain. Use WithDefaultEndpointTemplate and WithDefaultUniverseDomain to compose the default endpoint instead.  (SA1019)
client/echo_client.go:597:3: internaloption.WithDefaultEndpoint is deprecated: WithDefaultEndpoint does not support setting the universe domain. Use WithDefaultEndpointTemplate and WithDefaultUniverseDomain to compose the default endpoint instead.  (SA1019)
client/identity_client.go:68:3: internaloption.WithDefaultEndpoint is deprecated: WithDefaultEndpoint does not support setting the universe domain. Use WithDefaultEndpointTemplate and WithDefaultUniverseDomain to compose the default endpoint instead.  (SA1019)
client/identity_client.go:412:3: internaloption.WithDefaultEndpoint is deprecated: WithDefaultEndpoint does not support setting the universe domain. Use WithDefaultEndpointTemplate and WithDefaultUniverseDomain to compose the default endpoint instead.  (SA1019)
client/messaging_client.go:81:3: internaloption.WithDefaultEndpoint is deprecated: WithDefaultEndpoint does not support setting the universe domain. Use WithDefaultEndpointTemplate and WithDefaultUniverseDomain to compose the default endpoint instead.  (SA1019)
client/messaging_client.go:682:3: internaloption.WithDefaultEndpoint is deprecated: WithDefaultEndpoint does not support setting the universe domain. Use WithDefaultEndpointTemplate and WithDefaultUniverseDomain to compose the default endpoint instead.  (SA1019)
client/sequence_client.go:71:3: internaloption.WithDefaultEndpoint is deprecated: WithDefaultEndpoint does not support setting the universe domain. Use WithDefaultEndpointTemplate and WithDefaultUniverseDomain to compose the default endpoint instead.  (SA1019)
client/sequence_client.go:412:3: internaloption.WithDefaultEndpoint is deprecated: WithDefaultEndpoint does not support setting the universe domain. Use WithDefaultEndpointTemplate and WithDefaultUniverseDomain to compose the default endpoint instead.  (SA1019)
client/testing_client.go:69:3: internaloption.WithDefaultEndpoint is deprecated: WithDefaultEndpoint does not support setting the universe domain. Use WithDefaultEndpointTemplate and WithDefaultUniverseDomain to compose the default endpoint instead.  (SA1019)
client/testing_client.go:424:3: internaloption.WithDefaultEndpoint is deprecated: WithDefaultEndpoint does not support setting the universe domain. Use WithDefaultEndpointTemplate and WithDefaultUniverseDomain to compose the default endpoint instead.  (SA1019)
cmd/gapic-showcase/attempt-sequence.go:10:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/attempt-sequence.go:43:3: this value of in is never used (SA4006)
cmd/gapic-showcase/attempt-streaming-sequence.go:12:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/attempt-streaming-sequence.go:49:3: this value of in is never used (SA4006)
cmd/gapic-showcase/block.go:16:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/block.go:77:3: this value of in is never used (SA4006)
cmd/gapic-showcase/block.go:101:12: error strings should not be capitalized (ST1005)
cmd/gapic-showcase/chat.go:14:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/collect.go:14:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/compliance_service.go:72:12: error strings should not be capitalized (ST1005)
cmd/gapic-showcase/compliance_suite_errors_test.go:19:2: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package [io] or package [os], and those implementations should be preferred in new code. See the specific function documentation for details.  (SA1019)
cmd/gapic-showcase/compliance_suite_errors_test.go:24:2: package "github.com/googleapis/gapic-showcase/server/genproto" is being imported more than once (ST1019)
	cmd/gapic-showcase/compliance_suite_errors_test.go:25:2: other import of "github.com/googleapis/gapic-showcase/server/genproto"
cmd/gapic-showcase/compliance_suite_test.go:19:2: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package [io] or package [os], and those implementations should be preferred in new code. See the specific function documentation for details.  (SA1019)
cmd/gapic-showcase/compliance_suite_test.go:29:2: package "github.com/googleapis/gapic-showcase/server/genproto" is being imported more than once (ST1019)
	cmd/gapic-showcase/compliance_suite_test.go:30:2: other import of "github.com/googleapis/gapic-showcase/server/genproto"
cmd/gapic-showcase/connect.go:14:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/create-blurb.go:12:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/create-blurb.go:81:3: this value of in is never used (SA4006)
cmd/gapic-showcase/create-blurb.go:105:12: error strings should not be capitalized (ST1005)
cmd/gapic-showcase/create-blurb.go:117:12: error strings should not be capitalized (ST1005)
cmd/gapic-showcase/create-room.go:12:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/create-room.go:51:3: this value of in is never used (SA4006)
cmd/gapic-showcase/create-sequence.go:12:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/create-sequence.go:40:3: empty branch (SA9003)
cmd/gapic-showcase/create-sequence.go:47:3: this value of in is never used (SA4006)
cmd/gapic-showcase/create-session.go:12:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/create-session.go:44:3: empty branch (SA9003)
cmd/gapic-showcase/create-session.go:51:3: this value of in is never used (SA4006)
cmd/gapic-showcase/create-streaming-sequence.go:12:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/create-streaming-sequence.go:42:3: empty branch (SA9003)
cmd/gapic-showcase/create-streaming-sequence.go:49:3: this value of in is never used (SA4006)
cmd/gapic-showcase/create-user.go:12:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/create-user.go:69:3: this value of in is never used (SA4006)
cmd/gapic-showcase/delete-blurb.go:10:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/delete-blurb.go:43:3: this value of in is never used (SA4006)
cmd/gapic-showcase/delete-room.go:10:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/delete-room.go:43:3: this value of in is never used (SA4006)
cmd/gapic-showcase/delete-session.go:10:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/delete-session.go:34:3: empty branch (SA9003)
cmd/gapic-showcase/delete-session.go:41:3: this value of in is never used (SA4006)
cmd/gapic-showcase/delete-test.go:10:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/delete-test.go:34:3: empty branch (SA9003)
cmd/gapic-showcase/delete-test.go:41:3: this value of in is never used (SA4006)
cmd/gapic-showcase/delete-user.go:10:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/delete-user.go:43:3: this value of in is never used (SA4006)
cmd/gapic-showcase/echo-error-details.go:12:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/echo-error-details.go:38:3: empty branch (SA9003)
cmd/gapic-showcase/echo-error-details.go:45:3: this value of in is never used (SA4006)
cmd/gapic-showcase/echo.go:14:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/echo.go:83:3: this value of in is never used (SA4006)
cmd/gapic-showcase/echo.go:107:12: error strings should not be capitalized (ST1005)
cmd/gapic-showcase/echo_service.go:72:12: error strings should not be capitalized (ST1005)
cmd/gapic-showcase/endpoint.go:22:2: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package [io] or package [os], and those implementations should be preferred in new code. See the specific function documentation for details.  (SA1019)
cmd/gapic-showcase/endpoint.go:38:8: "google.golang.org/genproto/googleapis/iam/v1" is deprecated: Please use types in: cloud.google.com/go/iam/apiv1/iampb. Please read https://github.com/googleapis/google-cloud-go/blob/main/migration.md for more details.  (SA1019)
cmd/gapic-showcase/endpoint.go:39:8: "google.golang.org/genproto/googleapis/longrunning" is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb. Please read https://github.com/googleapis/google-cloud-go/blob/main/migration.md for more details.  (SA1019)
cmd/gapic-showcase/endpoint.go:256:2: lropb.RegisterOperationsServer is deprecated: Please use funcs in: cloud.google.com/go/longrunning/autogen/longrunningpb  (SA1019)
cmd/gapic-showcase/endpoint.go:258:2: iampb.RegisterIAMPolicyServer is deprecated: Please use funcs in: cloud.google.com/go/iam/apiv1/iampb  (SA1019)
cmd/gapic-showcase/endpoint_test.go:18:2: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package [io] or package [os], and those implementations should be preferred in new code. See the specific function documentation for details.  (SA1019)
cmd/gapic-showcase/expand.go:16:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/expand.go:60:3: empty branch (SA9003)
cmd/gapic-showcase/expand.go:67:3: this value of in is never used (SA4006)
cmd/gapic-showcase/gapic-showcase.go:11:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/gapic-showcase.go:12:2: "github.com/golang/protobuf/proto" is deprecated: Use the "google.golang.org/protobuf/proto" package instead.  (SA1019)
cmd/gapic-showcase/get-blurb.go:12:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/get-blurb.go:45:3: this value of in is never used (SA4006)
cmd/gapic-showcase/get-enum.go:12:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/get-enum.go:36:3: empty branch (SA9003)
cmd/gapic-showcase/get-enum.go:43:3: this value of in is never used (SA4006)
cmd/gapic-showcase/get-room.go:12:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/get-room.go:45:3: this value of in is never used (SA4006)
cmd/gapic-showcase/get-sequence-report.go:12:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/get-sequence-report.go:45:3: this value of in is never used (SA4006)
cmd/gapic-showcase/get-session.go:12:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/get-session.go:36:3: empty branch (SA9003)
cmd/gapic-showcase/get-session.go:43:3: this value of in is never used (SA4006)
cmd/gapic-showcase/get-streaming-sequence-report.go:12:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/get-streaming-sequence-report.go:45:3: this value of in is never used (SA4006)
cmd/gapic-showcase/get-user.go:12:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/get-user.go:45:3: this value of in is never used (SA4006)
cmd/gapic-showcase/identity_service.go:67:12: error strings should not be capitalized (ST1005)
cmd/gapic-showcase/list-blurbs.go:12:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/list-blurbs.go:51:3: this value of in is never used (SA4006)
cmd/gapic-showcase/list-rooms.go:12:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/list-rooms.go:40:3: empty branch (SA9003)
cmd/gapic-showcase/list-rooms.go:47:3: this value of in is never used (SA4006)
cmd/gapic-showcase/list-sessions.go:12:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/list-sessions.go:40:3: empty branch (SA9003)
cmd/gapic-showcase/list-sessions.go:47:3: this value of in is never used (SA4006)
cmd/gapic-showcase/list-tests.go:12:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/list-tests.go:42:3: empty branch (SA9003)
cmd/gapic-showcase/list-tests.go:49:3: this value of in is never used (SA4006)
cmd/gapic-showcase/list-users.go:12:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/list-users.go:40:3: empty branch (SA9003)
cmd/gapic-showcase/list-users.go:47:3: this value of in is never used (SA4006)
cmd/gapic-showcase/messaging_service.go:76:12: error strings should not be capitalized (ST1005)
cmd/gapic-showcase/paged-expand-legacy-mapped.go:12:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/paged-expand-legacy-mapped.go:51:3: this value of in is never used (SA4006)
cmd/gapic-showcase/paged-expand.go:12:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/paged-expand.go:51:3: this value of in is never used (SA4006)
cmd/gapic-showcase/repeat-data-body-info.go:12:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/repeat-data-body-info.go:218:3: empty branch (SA9003)
cmd/gapic-showcase/repeat-data-body-info.go:225:3: this value of in is never used (SA4006)
cmd/gapic-showcase/repeat-data-body-patch.go:12:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/repeat-data-body-patch.go:218:3: empty branch (SA9003)
cmd/gapic-showcase/repeat-data-body-patch.go:225:3: this value of in is never used (SA4006)
cmd/gapic-showcase/repeat-data-body-put.go:12:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/repeat-data-body-put.go:218:3: empty branch (SA9003)
cmd/gapic-showcase/repeat-data-body-put.go:225:3: this value of in is never used (SA4006)
cmd/gapic-showcase/repeat-data-body.go:12:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/repeat-data-body.go:218:3: empty branch (SA9003)
cmd/gapic-showcase/repeat-data-body.go:225:3: this value of in is never used (SA4006)
cmd/gapic-showcase/repeat-data-path-resource.go:12:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/repeat-data-path-resource.go:218:3: empty branch (SA9003)
cmd/gapic-showcase/repeat-data-path-resource.go:225:3: this value of in is never used (SA4006)
cmd/gapic-showcase/repeat-data-path-trailing-resource.go:12:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/repeat-data-path-trailing-resource.go:218:3: empty branch (SA9003)
cmd/gapic-showcase/repeat-data-path-trailing-resource.go:225:3: this value of in is never used (SA4006)
cmd/gapic-showcase/repeat-data-query.go:12:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/repeat-data-query.go:218:3: empty branch (SA9003)
cmd/gapic-showcase/repeat-data-query.go:225:3: this value of in is never used (SA4006)
cmd/gapic-showcase/repeat-data-simple-path.go:12:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/repeat-data-simple-path.go:218:3: empty branch (SA9003)
cmd/gapic-showcase/repeat-data-simple-path.go:225:3: this value of in is never used (SA4006)
cmd/gapic-showcase/report-session.go:12:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/report-session.go:36:3: empty branch (SA9003)
cmd/gapic-showcase/report-session.go:43:3: this value of in is never used (SA4006)
cmd/gapic-showcase/run.go:41:38: os.Kill cannot be trapped (did you mean syscall.SIGTERM?) (SA1016)
cmd/gapic-showcase/search-blurbs.go:12:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/search-blurbs.go:65:3: this value of in is never used (SA4006)
cmd/gapic-showcase/search-blurbs.go:148:4: should use fmt.Printf instead of fmt.Println(fmt.Sprintf(...)) (but don't forget the newline) (S1038)
cmd/gapic-showcase/search-blurbs.go:150:4: should use fmt.Printf instead of fmt.Println(fmt.Sprintf(...)) (but don't forget the newline) (S1038)
cmd/gapic-showcase/send-blurbs.go:14:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/sequence_service.go:68:12: error strings should not be capitalized (ST1005)
cmd/gapic-showcase/stream-blurbs.go:12:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/stream-blurbs.go:55:3: this value of in is never used (SA4006)
cmd/gapic-showcase/testing_service.go:70:12: error strings should not be capitalized (ST1005)
cmd/gapic-showcase/update-blurb.go:14:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/update-blurb.go:83:3: this value of in is never used (SA4006)
cmd/gapic-showcase/update-blurb.go:107:12: error strings should not be capitalized (ST1005)
cmd/gapic-showcase/update-blurb.go:119:12: error strings should not be capitalized (ST1005)
cmd/gapic-showcase/update-room.go:14:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/update-room.go:57:3: this value of in is never used (SA4006)
cmd/gapic-showcase/update-user.go:14:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/update-user.go:75:3: this value of in is never used (SA4006)
cmd/gapic-showcase/verify-enum.go:12:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/verify-enum.go:44:3: empty branch (SA9003)
cmd/gapic-showcase/verify-enum.go:51:3: this value of in is never used (SA4006)
cmd/gapic-showcase/verify-test.go:12:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/verify-test.go:38:3: empty branch (SA9003)
cmd/gapic-showcase/verify-test.go:45:3: this value of in is never used (SA4006)
cmd/gapic-showcase/wait.go:16:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
cmd/gapic-showcase/wait.go:109:3: this value of in is never used (SA4006)
cmd/gapic-showcase/wait.go:133:12: error strings should not be capitalized (ST1005)
cmd/gapic-showcase/wait.go:145:12: error strings should not be capitalized (ST1005)
cmd/gapic-showcase/wait.go:229:4: should use fmt.Printf instead of fmt.Println(fmt.Sprintf(...)) (but don't forget the newline) (S1038)
cmd/gapic-showcase/wait.go:231:4: should use fmt.Printf instead of fmt.Println(fmt.Sprintf(...)) (but don't forget the newline) (S1038)
server/services/echo_service.go:26:2: "github.com/golang/protobuf/ptypes" is deprecated: Well-known types have specialized functionality directly injected into the generated packages for each message type. See the deprecation notice for each function for the suggested alternative.  (SA1019)
server/services/echo_service.go:29:8: "google.golang.org/genproto/googleapis/longrunning" is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb. Please read https://github.com/googleapis/google-cloud-go/blob/main/migration.md for more details.  (SA1019)
server/services/echo_service.go:264:74: lropb.Operation is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb  (SA1019)
server/services/echo_service.go:271:10: ptypes.Duration is deprecated: Call the dur.AsDuration and dur.CheckValid methods instead.  (SA1019)
server/services/echo_service_test.go:27:2: "github.com/golang/protobuf/proto" is deprecated: Use the "google.golang.org/protobuf/proto" package instead.  (SA1019)
server/services/echo_service_test.go:28:2: "github.com/golang/protobuf/ptypes" is deprecated: Well-known types have specialized functionality directly injected into the generated packages for each message type. See the deprecation notice for each function for the suggested alternative.  (SA1019)
server/services/echo_service_test.go:824:16: ptypes.TimestampProto is deprecated: Call the timestamppb.New function instead.  (SA1019)
server/services/iam_policy_service.go:21:2: "github.com/golang/protobuf/proto" is deprecated: Use the "google.golang.org/protobuf/proto" package instead.  (SA1019)
server/services/iam_policy_service.go:22:8: "google.golang.org/genproto/googleapis/iam/v1" is deprecated: Please use types in: cloud.google.com/go/iam/apiv1/iampb. Please read https://github.com/googleapis/google-cloud-go/blob/main/migration.md for more details.  (SA1019)
server/services/iam_policy_service.go:32:27: iampb.IAMPolicyServer is deprecated: Please use types in: cloud.google.com/go/iam/apiv1/iampb  (SA1019)
server/services/iam_policy_service.go:34:25: iampb.Policy is deprecated: Please use types in: cloud.google.com/go/iam/apiv1/iampb  (SA1019)
server/services/iam_policy_service.go:42:23: iampb.Policy is deprecated: Please use types in: cloud.google.com/go/iam/apiv1/iampb  (SA1019)
server/services/iam_policy_service.go:46:69: iampb.GetIamPolicyRequest is deprecated: Please use types in: cloud.google.com/go/iam/apiv1/iampb  (SA1019)
server/services/iam_policy_service.go:46:98: iampb.Policy is deprecated: Please use types in: cloud.google.com/go/iam/apiv1/iampb  (SA1019)
server/services/iam_policy_service.go:60:15: iampb.Policy is deprecated: Please use types in: cloud.google.com/go/iam/apiv1/iampb  (SA1019)
server/services/iam_policy_service.go:64:69: iampb.SetIamPolicyRequest is deprecated: Please use types in: cloud.google.com/go/iam/apiv1/iampb  (SA1019)
server/services/iam_policy_service.go:64:98: iampb.Policy is deprecated: Please use types in: cloud.google.com/go/iam/apiv1/iampb  (SA1019)
server/services/iam_policy_service.go:76:15: iampb.Policy is deprecated: Please use types in: cloud.google.com/go/iam/apiv1/iampb  (SA1019)
server/services/iam_policy_service.go:83:75: iampb.TestIamPermissionsRequest is deprecated: Please use types in: cloud.google.com/go/iam/apiv1/iampb  (SA1019)
server/services/iam_policy_service.go:83:110: iampb.TestIamPermissionsResponse is deprecated: Please use types in: cloud.google.com/go/iam/apiv1/iampb  (SA1019)
server/services/iam_policy_service.go:95:10: iampb.TestIamPermissionsResponse is deprecated: Please use types in: cloud.google.com/go/iam/apiv1/iampb  (SA1019)
server/services/iam_policy_service_test.go:23:8: "google.golang.org/genproto/googleapis/iam/v1" is deprecated: Please use types in: cloud.google.com/go/iam/apiv1/iampb. Please read https://github.com/googleapis/google-cloud-go/blob/main/migration.md for more details.  (SA1019)
server/services/iam_policy_service_test.go:31:13: iampb.Policy is deprecated: Please use types in: cloud.google.com/go/iam/apiv1/iampb  (SA1019)
server/services/iam_policy_service_test.go:33:16: iampb.Binding is deprecated: Please use types in: cloud.google.com/go/iam/apiv1/iampb  (SA1019)
server/services/iam_policy_service_test.go:39:50: iampb.SetIamPolicyRequest is deprecated: Please use types in: cloud.google.com/go/iam/apiv1/iampb  (SA1019)
server/services/iam_policy_service_test.go:48:49: iampb.GetIamPolicyRequest is deprecated: Please use types in: cloud.google.com/go/iam/apiv1/iampb  (SA1019)
server/services/iam_policy_service_test.go:57:58: iampb.TestIamPermissionsRequest is deprecated: Please use types in: cloud.google.com/go/iam/apiv1/iampb  (SA1019)
server/services/iam_policy_service_test.go:87:53: iampb.GetIamPolicyRequest is deprecated: Please use types in: cloud.google.com/go/iam/apiv1/iampb  (SA1019)
server/services/iam_policy_service_test.go:115:53: iampb.SetIamPolicyRequest is deprecated: Please use types in: cloud.google.com/go/iam/apiv1/iampb  (SA1019)
server/services/iam_policy_service_test.go:143:59: iampb.TestIamPermissionsRequest is deprecated: Please use types in: cloud.google.com/go/iam/apiv1/iampb  (SA1019)
server/services/identity_service.go:22:2: "github.com/golang/protobuf/proto" is deprecated: Use the "google.golang.org/protobuf/proto" package instead.  (SA1019)
server/services/identity_service.go:23:2: "github.com/golang/protobuf/ptypes" is deprecated: Well-known types have specialized functionality directly injected into the generated packages for each message type. See the deprecation notice for each function for the suggested alternative.  (SA1019)
server/services/identity_service.go:77:9: ptypes.TimestampNow is deprecated: Call the timestamppb.Now function instead.  (SA1019)
server/services/identity_service.go:133:23: ptypes.TimestampNow is deprecated: Call the timestamppb.Now function instead.  (SA1019)
server/services/identity_service_test.go:23:2: "github.com/golang/protobuf/proto" is deprecated: Use the "google.golang.org/protobuf/proto" package instead.  (SA1019)
server/services/identity_service_test.go:122:2: this value of err is never used (SA4006)
server/services/identity_service_test.go:135:2: this value of err is never used (SA4006)
server/services/identity_service_test.go:211:2: this value of u is never used (SA4006)
server/services/messaging_service.go:27:2: "github.com/golang/protobuf/proto" is deprecated: Use the "google.golang.org/protobuf/proto" package instead.  (SA1019)
server/services/messaging_service.go:28:2: "github.com/golang/protobuf/ptypes" is deprecated: Well-known types have specialized functionality directly injected into the generated packages for each message type. See the deprecation notice for each function for the suggested alternative.  (SA1019)
server/services/messaging_service.go:32:2: "google.golang.org/genproto/googleapis/longrunning" is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb. Please read https://github.com/googleapis/google-cloud-go/blob/main/migration.md for more details.  (SA1019)
server/services/messaging_service.go:128:9: ptypes.TimestampNow is deprecated: Call the timestamppb.Now function instead.  (SA1019)
server/services/messaging_service.go:196:23: ptypes.TimestampNow is deprecated: Call the timestamppb.Now function instead.  (SA1019)
server/services/messaging_service.go:298:9: ptypes.TimestampNow is deprecated: Call the timestamppb.Now function instead.  (SA1019)
server/services/messaging_service.go:366:23: ptypes.TimestampNow is deprecated: Call the timestamppb.Now function instead.  (SA1019)
server/services/messaging_service.go:457:95: longrunning.Operation is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb  (SA1019)
server/services/messaging_service.go:467:13: ptypes.MarshalAny is deprecated: Call the anypb.New function instead.  (SA1019)
server/services/messaging_service.go:470:17: ptypes.DurationProto is deprecated: Call the durationpb.New function instead.  (SA1019)
server/services/messaging_service.go:474:10: longrunning.Operation is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb  (SA1019)
server/services/messaging_service.go:485:21: ptypes.Timestamp is deprecated: Call the ts.AsTime and ts.CheckValid methods instead.  (SA1019)
server/services/messaging_service.go:541:18: ptypes.MarshalAny is deprecated: Call the anypb.New function instead.  (SA1019)
server/services/messaging_service.go:643:2: field parent is unused (U1000)
server/services/messaging_service_test.go:27:2: "github.com/golang/protobuf/proto" is deprecated: Use the "google.golang.org/protobuf/proto" package instead.  (SA1019)
server/services/messaging_service_test.go:28:2: "github.com/golang/protobuf/ptypes" is deprecated: Well-known types have specialized functionality directly injected into the generated packages for each message type. See the deprecation notice for each function for the suggested alternative.  (SA1019)
server/services/messaging_service_test.go:108:2: this value of err is never used (SA4006)
server/services/messaging_service_test.go:121:2: this value of err is never used (SA4006)
server/services/messaging_service_test.go:849:18: ptypes.TimestampProto is deprecated: Call the timestamppb.New function instead.  (SA1019)
server/services/messaging_service_test.go:1038:18: ptypes.TimestampProto is deprecated: Call the timestamppb.New function instead.  (SA1019)
server/services/messaging_service_test.go:1123:18: ptypes.TimestampProto is deprecated: Call the timestamppb.New function instead.  (SA1019)
server/services/messaging_service_test.go:1312:2: ptypes.UnmarshalAny is deprecated: Call the any.UnmarshalTo method instead.  (SA1019)
server/services/messaging_service_test.go:1385:2: ptypes.UnmarshalAny is deprecated: Call the any.UnmarshalTo method instead.  (SA1019)
server/services/messaging_service_test.go:1445:2: ptypes.UnmarshalAny is deprecated: Call the any.UnmarshalTo method instead.  (SA1019)
server/services/messaging_service_test.go:1470:2: field nextMu is unused (U1000)
server/services/messaging_service_test.go:1730:2: field respMu is unused (U1000)
server/services/messaging_service_test.go:1733:2: field nextMu is unused (U1000)
server/services/operations_service.go:25:2: "github.com/golang/protobuf/proto" is deprecated: Use the "google.golang.org/protobuf/proto" package instead.  (SA1019)
server/services/operations_service.go:26:2: "github.com/golang/protobuf/ptypes" is deprecated: Well-known types have specialized functionality directly injected into the generated packages for each message type. See the deprecation notice for each function for the suggested alternative.  (SA1019)
server/services/operations_service.go:30:8: "google.golang.org/genproto/googleapis/longrunning" is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb. Please read https://github.com/googleapis/google-cloud-go/blob/main/migration.md for more details.  (SA1019)
server/services/operations_service.go:36:59: lropb.OperationsServer is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb  (SA1019)
server/services/operations_service.go:45:70: lropb.GetOperationRequest is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb  (SA1019)
server/services/operations_service.go:45:99: lropb.Operation is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb  (SA1019)
server/services/operations_service.go:55:47: lropb.GetOperationRequest is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb  (SA1019)
server/services/operations_service.go:55:76: lropb.Operation is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb  (SA1019)
server/services/operations_service.go:76:55: lropb.GetOperationRequest is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb  (SA1019)
server/services/operations_service.go:76:84: lropb.Operation is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb  (SA1019)
server/services/operations_service.go:96:2: this value of err is never used (SA4006)
server/services/operations_service.go:105:13: lropb.Operation is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb  (SA1019)
server/services/operations_service.go:110:13: ptypes.MarshalAny is deprecated: Call the anypb.New function instead.  (SA1019)
server/services/operations_service.go:123:7: should use strings.Contains(b.GetText(), s) instead (S1003)
server/services/operations_service.go:132:72: lropb.CancelOperationRequest is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb  (SA1019)
server/services/operations_service.go:140:71: lropb.ListOperationsRequest is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb  (SA1019)
server/services/operations_service.go:140:102: lropb.ListOperationsResponse is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb  (SA1019)
server/services/operations_service.go:145:20: lropb.Operation is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb  (SA1019)
server/services/operations_service.go:152:37: lropb.Operation is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb  (SA1019)
server/services/operations_service.go:159:36: lropb.Operation is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb  (SA1019)
server/services/operations_service.go:165:10: lropb.ListOperationsResponse is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb  (SA1019)
server/services/operations_service.go:171:72: lropb.DeleteOperationRequest is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb  (SA1019)
server/services/operations_service.go:179:70: lropb.WaitOperationRequest is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb  (SA1019)
server/services/operations_service.go:179:100: lropb.Operation is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb  (SA1019)
server/services/operations_service.go:191:10: lropb.Operation is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb  (SA1019)
server/services/operations_service_test.go:24:2: "github.com/golang/protobuf/proto" is deprecated: Use the "google.golang.org/protobuf/proto" package instead.  (SA1019)
server/services/operations_service_test.go:25:2: "github.com/golang/protobuf/ptypes" is deprecated: Well-known types have specialized functionality directly injected into the generated packages for each message type. See the deprecation notice for each function for the suggested alternative.  (SA1019)
server/services/operations_service_test.go:28:8: "google.golang.org/genproto/googleapis/longrunning" is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb. Please read https://github.com/googleapis/google-cloud-go/blob/main/migration.md for more details.  (SA1019)
server/services/operations_service_test.go:34:16: ptypes.TimestampProto is deprecated: Call the timestamppb.New function instead.  (SA1019)
server/services/operations_service_test.go:37:10: lropb.GetOperationRequest is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb  (SA1019)
server/services/operations_service_test.go:123:10: lropb.GetOperationRequest is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb  (SA1019)
server/services/operations_service_test.go:166:2: ptypes.UnmarshalAny is deprecated: Call the any.UnmarshalTo method instead.  (SA1019)
server/services/operations_service_test.go:186:10: lropb.GetOperationRequest is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb  (SA1019)
server/services/operations_service_test.go:203:11: lropb.GetOperationRequest is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb  (SA1019)
server/services/operations_service_test.go:225:11: lropb.GetOperationRequest is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb  (SA1019)
server/services/operations_service_test.go:239:58: lropb.CancelOperationRequest is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb  (SA1019)
server/services/operations_service_test.go:249:58: lropb.CancelOperationRequest is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb  (SA1019)
server/services/operations_service_test.go:258:59: lropb.ListOperationsRequest is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb  (SA1019)
server/services/operations_service_test.go:268:58: lropb.ListOperationsRequest is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb  (SA1019)
server/services/operations_service_test.go:285:57: lropb.ListOperationsRequest is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb  (SA1019)
server/services/operations_service_test.go:294:58: lropb.DeleteOperationRequest is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb  (SA1019)
server/services/operations_service_test.go:304:58: lropb.DeleteOperationRequest is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb  (SA1019)
server/services/operations_service_test.go:316:59: lropb.WaitOperationRequest is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb  (SA1019)
server/services/operations_service_test.go:336:56: lropb.WaitOperationRequest is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb  (SA1019)
server/services/sequence_service.go:24:2: "github.com/golang/protobuf/ptypes" is deprecated: Well-known types have specialized functionality directly injected into the generated packages for each message type. See the deprecation notice for each function for the suggested alternative.  (SA1019)
server/services/sequence_service.go:96:14: ptypes.TimestampProto is deprecated: Call the timestamppb.New function instead.  (SA1019)
server/services/sequence_service.go:128:14: ptypes.DurationProto is deprecated: Call the durationpb.New function instead.  (SA1019)
server/services/sequence_service.go:133:14: ptypes.TimestampProto is deprecated: Call the timestamppb.New function instead.  (SA1019)
server/services/sequence_service.go:271:14: ptypes.DurationProto is deprecated: Call the durationpb.New function instead.  (SA1019)
server/services/sequence_service.go:276:14: ptypes.TimestampProto is deprecated: Call the timestamppb.New function instead.  (SA1019)
server/services/sequence_service_test.go:24:2: "github.com/golang/protobuf/ptypes" is deprecated: Well-known types have specialized functionality directly injected into the generated packages for each message type. See the deprecation notice for each function for the suggested alternative.  (SA1019)
server/services/sequence_service_test.go:77:12: ptypes.DurationProto is deprecated: Call the durationpb.New function instead.  (SA1019)
server/services/sequence_service_test.go:81:12: ptypes.DurationProto is deprecated: Call the durationpb.New function instead.  (SA1019)
server/services/sequence_service_test.go:251:30: func (*mockStreamSequence).verify is unused (U1000)
server/services/sequence_service_test.go:297:12: ptypes.DurationProto is deprecated: Call the durationpb.New function instead.  (SA1019)
server/services/sequence_service_test.go:301:12: ptypes.DurationProto is deprecated: Call the durationpb.New function instead.  (SA1019)
server/services/sequence_service_test.go:362:12: ptypes.DurationProto is deprecated: Call the durationpb.New function instead.  (SA1019)
server/services/sequence_service_test.go:366:12: ptypes.DurationProto is deprecated: Call the durationpb.New function instead.  (SA1019)
server/services/services.go:24:8: "google.golang.org/genproto/googleapis/iam/v1" is deprecated: Please use types in: cloud.google.com/go/iam/apiv1/iampb. Please read https://github.com/googleapis/google-cloud-go/blob/main/migration.md for more details.  (SA1019)
server/services/services.go:25:8: "google.golang.org/genproto/googleapis/longrunning" is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb. Please read https://github.com/googleapis/google-cloud-go/blob/main/migration.md for more details.  (SA1019)
server/services/services.go:40:19: lropb.OperationsServer is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb  (SA1019)
server/services/services.go:42:19: iampb.IAMPolicyServer is deprecated: Please use types in: cloud.google.com/go/iam/apiv1/iampb  (SA1019)
server/services/test_common.go:19:8: "google.golang.org/genproto/googleapis/longrunning" is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb. Please read https://github.com/googleapis/google-cloud-go/blob/main/migration.md for more details.  (SA1019)
server/services/test_common.go:28:49: lropb.Operation is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb  (SA1019)
server/services/testing_service.go:33:10: unnecessary use of fmt.Sprintf (S1039)
server/services/testing_service_test.go:22:2: "github.com/golang/protobuf/proto" is deprecated: Use the "google.golang.org/protobuf/proto" package instead.  (SA1019)
server/services/testing_service_test.go:77:2: this value of err is never used (SA4006)
server/services/testing_service_test.go:90:2: this value of err is never used (SA4006)
server/session_test.go:21:2: "github.com/golang/protobuf/proto" is deprecated: Use the "google.golang.org/protobuf/proto" package instead.  (SA1019)
server/spec/v1/unary.go:23:2: "github.com/golang/protobuf/proto" is deprecated: Use the "google.golang.org/protobuf/proto" package instead.  (SA1019)
server/spec/v1/unary_test.go:21:2: "github.com/golang/protobuf/proto" is deprecated: Use the "google.golang.org/protobuf/proto" package instead.  (SA1019)
server/waiter.go:22:2: "github.com/golang/protobuf/proto" is deprecated: Use the "google.golang.org/protobuf/proto" package instead.  (SA1019)
server/waiter.go:23:2: "github.com/golang/protobuf/ptypes" is deprecated: Well-known types have specialized functionality directly injected into the generated packages for each message type. See the deprecation notice for each function for the suggested alternative.  (SA1019)
server/waiter.go:25:8: "google.golang.org/genproto/googleapis/longrunning" is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb. Please read https://github.com/googleapis/google-cloud-go/blob/main/migration.md for more details.  (SA1019)
server/waiter.go:39:29: lropb.Operation is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb  (SA1019)
server/waiter.go:46:49: lropb.Operation is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb  (SA1019)
server/waiter.go:49:18: ptypes.Duration is deprecated: Call the dur.AsDuration and dur.CheckValid methods instead.  (SA1019)
server/waiter.go:53:16: ptypes.Timestamp is deprecated: Call the ts.AsTime and ts.CheckValid methods instead.  (SA1019)
server/waiter.go:55:21: ptypes.TimestampProto is deprecated: Call the timestamppb.New function instead.  (SA1019)
server/waiter.go:65:13: lropb.Operation is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb  (SA1019)
server/waiter.go:75:14: ptypes.MarshalAny is deprecated: Call the anypb.New function instead.  (SA1019)
server/waiter.go:80:14: ptypes.MarshalAny is deprecated: Call the anypb.New function instead.  (SA1019)
server/waiter_test.go:23:2: "github.com/golang/protobuf/proto" is deprecated: Use the "google.golang.org/protobuf/proto" package instead.  (SA1019)
server/waiter_test.go:24:2: "github.com/golang/protobuf/ptypes" is deprecated: Well-known types have specialized functionality directly injected into the generated packages for each message type. See the deprecation notice for each function for the suggested alternative.  (SA1019)
server/waiter_test.go:27:8: "google.golang.org/genproto/googleapis/longrunning" is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb. Please read https://github.com/googleapis/google-cloud-go/blob/main/migration.md for more details.  (SA1019)
server/waiter_test.go:53:10: ptypes.DurationProto is deprecated: Call the durationpb.New function instead.  (SA1019)
server/waiter_test.go:73:3: ptypes.UnmarshalAny is deprecated: Call the any.UnmarshalTo method instead.  (SA1019)
server/waiter_test.go:113:2: ptypes.UnmarshalAny is deprecated: Call the any.UnmarshalTo method instead.  (SA1019)
server/waiter_test.go:150:11: ptypes.TimestampProto is deprecated: Call the timestamppb.New function instead.  (SA1019)
server/waiter_test.go:154:55: lropb.Operation is deprecated: Please use types in: cloud.google.com/go/longrunning/autogen/longrunningpb  (SA1019)
util/compile_protos.go:19:2: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package [io] or package [os], and those implementations should be preferred in new code. See the specific function documentation for details.  (SA1019)
util/genrest/gomodel/gomodel.go:90:23: error strings should not end with punctuation or newlines (ST1005)
util/genrest/goviewcreator_test.go:18:2: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package [io] or package [os], and those implementations should be preferred in new code. See the specific function documentation for details.  (SA1019)
util/genrest/internal/pbinfo/pbinfo.go:28:2: "github.com/golang/protobuf/proto" is deprecated: Use the "google.golang.org/protobuf/proto" package instead.  (SA1019)
util/genrest/protomodelcreator.go:19:2: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package [io] or package [os], and those implementations should be preferred in new code. See the specific function documentation for details.  (SA1019)
util/genrest/resttools/checkrequestformat.go:21:2: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package [io] or package [os], and those implementations should be preferred in new code. See the specific function documentation for details.  (SA1019)
util/genrest/resttools/keysmatching.go:29:11: unnecessary assignment to the blank identifier (S1005)
@julieqiu julieqiu added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. process process/chore oriented work and removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. process process/chore oriented work
Projects
None yet
Development

No branches or pull requests

1 participant