Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unescape Java keyword field names when generating HttpJson unit tests. #1654

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

blakeli0
Copy link
Collaborator

Unescape Java keyword field names when generating HttpJson unit tests, if the field is also a resource and used for http annotations. Otherwise we would not be able to populate default values for the field when generating HttpJson unit tests.

fixes: #1652

@blakeli0 blakeli0 requested a review from a team as a code owner April 25, 2023 04:31
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Apr 25, 2023
@sonarqubecloud
Copy link

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@blakeli0 blakeli0 merged commit 5fd79ea into main Apr 25, 2023
@blakeli0 blakeli0 deleted the fix-httpjson-tests branch April 25, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated HttpJson unit tests would fail if the request contains a field name that is a Java keyword
2 participants