chore: Update steps to generate a library locally #1539
Conversation
|
[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!
|
|
[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!
|
lqiu96
changed the title
|
[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!
|
| @@ -109,16 +109,22 @@ To generate a production GAPIC API: | |||
| strip_prefix = "gapic-generator-java-%s" % _gapic_generator_java_version, | |||
| urls = ["https://github.com/googleapis/gapic-generator-java/archive/v%s.zip" % _gapic_generator_java_version], | |||
| ) | |||
|
|
|||
| # gax-java is part of gapic-generator-java repository | |||
There was a problem hiding this comment.
Is this required? Tomo and I actually just discussed today, since gax is already included in the gapic-generator-java jar, as long as we built a new jar with local gax changes, we shouldn't need this step.
There was a problem hiding this comment.
When I remove this reference to gax_java and point it to the generator_java instead, I get this error when invoking the command:
ERROR: /Users/lawrenceqiu/IdeaProjects/googleapis/google/cloud/talent/v4/BUILD.bazel:88:19: no such package '@com_google_api_gax_java//gax': The repository '@com_google_api_gax_java' could not be resolved: Repository '@com_google_api_gax_java' is not defined and referenced by '//google/cloud/talent/v4:talent_java_gapic_test'
Seems like there is reference to com_google_api_gax_java inside the java_gapic_library bazel rule?
There was a problem hiding this comment.
I see the problem now, yes there are gax references in java_gapic_library that is used for generating the gradle files. Now that gax repo is pointed to gapic-generator-java/gax-java, we have to point it to local folder otherwise it will complaint something about "SNAPSHOR version does not exist". Thanks for fixing it!
CC: @suztomo I know you might be working on improving this part, this is one more side effect of the gradle files generation.
Thank you for opening a Pull Request! For general contributing guidelines, please refer to contributing guide
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1499 ☕️
Ran into this issue when doing some testing for the release manager. This is what I did to resolve it locally.