Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add the google.rpc.context.AuditContext and google.rpc.http message to the open source #1248

Merged
merged 2 commits into from
Jan 13, 2023

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Jan 13, 2023

Regeneration of the code based on googleapis/java-common-protos#491

Command:

suztomo@suztomo:~/gapic-generator-java$ docker run --rm --user $(id -u):$(id -g)   -v $(pwd):/repo -v /tmp/googleapis-gen:/googleapis-gen -w /repo   --env HOME=/tmp   gcr.io/cloud-devrel-public-resources/owlbot-cli:latest copy-code   --source-repo=/googleapis-gen   --config-file=java-common-protos/.OwlBot.yaml

Copying metadata from googleapis/java-common-protos#491:

PiperOrigin-RevId: 495222106

Source-Link: googleapis/googleapis@f36c650

Source-Link: https://github.com/googleapis/googleapis-gen/commit/8c5e5f8a29444bbc2c91df29b059e0c7f1fa13af
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGM1ZTVmOGEyOTQ0NGJiYzJjOTFkZjI5YjA1OWUwYzdmMWZhMTNhZiJ9

BEGIN_NESTED_COMMIT
build: remove obsolete field in client.proto
PiperOrigin-RevId: 493425327

Source-Link: googleapis/googleapis@d7687dc

Source-Link: https://github.com/googleapis/googleapis-gen/commit/d6989a57a11a571973bcba915da8d0cd25dc9fb1
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDY5ODlhNTdhMTFhNTcxOTczYmNiYTkxNWRhOGQwY2QyNWRjOWZiMSJ9
END_NESTED_COMMIT

@suztomo suztomo requested a review from a team as a code owner January 13, 2023 17:14
@suztomo suztomo added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 13, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 13, 2023
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 22 Code Smells

0.0% 0.0% Coverage
50.2% 50.2% Duplication

@suztomo
Copy link
Member Author

suztomo commented Jan 13, 2023

SonarCloud Code Analysis Failing after 1m — Quality Gate failed

The protobuf-generated code does not come with test. This is expected.

@suztomo
Copy link
Member Author

suztomo commented Jan 13, 2023

@likeulb @meltsufin This is the same code generation as googleapis/java-common-protos#491, with regard to email "Re: Question about the maven repositiory"

@suztomo suztomo requested a review from meltsufin January 13, 2023 18:19
@suztomo suztomo merged commit 1538ad8 into googleapis:main Jan 13, 2023
@suztomo
Copy link
Member Author

suztomo commented Jan 13, 2023

(I forgot to add the metadata in the commit log. But it should be fine)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants