Stop suppressing warnings with -Wno-cast-function-type #315

aalexand · 2018-10-22T16:19:30Z

Mon Oct 22 15:22:36 UTC 2018: ++ node -e 'console.log(require('''./package.json''').version);'
Mon Oct 22 15:22:36 UTC 2018: + VERSION=0.2.2
Mon Oct 22 15:22:36 UTC 2018: + PROFILER=/cloud-profiler-nodejs/google-cloud-profiler-0.2.2.tgz
Mon Oct 22 15:22:36 UTC 2018: + TESTDIR=/test
Mon Oct 22 15:22:36 UTC 2018: + mkdir -p /test
Mon Oct 22 15:22:36 UTC 2018: + cp -r testing/busybench /test
Mon Oct 22 15:22:36 UTC 2018: + cd /test/busybench
Mon Oct 22 15:22:36 UTC 2018: + retry npm install --nodedir=/.nvm/versions/node/v10.12.0 /cloud-profiler-nodejs/google-cloud-profiler-0.2.2.tgz
Mon Oct 22 15:22:36 UTC 2018: + for i in {1..3}
Mon Oct 22 15:22:36 UTC 2018: + npm install --nodedir=/.nvm/versions/node/v10.12.0 /cloud-profiler-nodejs/google-cloud-profiler-0.2.2.tgz
Mon Oct 22 15:22:40 UTC 2018: In file included from ../../../nan/nan_new.h:189:0,
Mon Oct 22 15:22:40 UTC 2018: from ../../../nan/nan.h:222,
Mon Oct 22 15:22:40 UTC 2018: from ../bindings/sampling-heap-profiler.cc:19:
Mon Oct 22 15:22:40 UTC 2018: ../../../nan/nan_implementation_12_inl.h: In static member function ‘static Nan::imp::FactoryBase<v8::StringObject>::return_t Nan::imp::Factory<v8::StringObject>::New(v8::Local<v8::String>)’:
Mon Oct 22 15:22:40 UTC 2018: ../../../nan/nan_implementation_12_inl.h:340:37: warning: ‘static v8::Local<v8::Value> v8::StringObject::New(v8::Local<v8::String>)’ is deprecated: Use Isolate* version [-Wdeprecated-declarations]
Mon Oct 22 15:22:40 UTC 2018: return v8::StringObject::New(value).As<v8::StringObject>();
Mon Oct 22 15:22:40 UTC 2018: ^
Mon Oct 22 15:22:40 UTC 2018: In file included from /.nvm/versions/node/v10.12.0/include/node/v8.h:26:0,
Mon Oct 22 15:22:40 UTC 2018: from /.nvm/versions/node/v10.12.0/include/node/v8-profiler.h:10,
Mon Oct 22 15:22:40 UTC 2018: from ../bindings/sampling-heap-profiler.cc:18:
Mon Oct 22 15:22:40 UTC 2018: /.nvm/versions/node/v10.12.0/include/node/v8.h:5053:37: note: declared here
Mon Oct 22 15:22:40 UTC 2018: static Local<Value> New(Local<String> value));
Mon Oct 22 15:22:40 UTC 2018: ^
Mon Oct 22 15:22:40 UTC 2018: /.nvm/versions/node/v10.12.0/include/node/v8config.h:324:3: note: in definition of macro ‘V8_DEPRECATED’
Mon Oct 22 15:22:40 UTC 2018: declarator __attribute__((deprecated(message)))
Mon Oct 22 15:22:40 UTC 2018: ^~~~~~~~~~
Mon Oct 22 15:22:40 UTC 2018: In file included from ../bindings/sampling-heap-profiler.cc:19:0:
Mon Oct 22 15:22:40 UTC 2018: ../../../nan/nan.h: In constructor ‘Nan::Utf8String::Utf8String(v8::Local<v8::Value>)’:
Mon Oct 22 15:22:40 UTC 2018: ../../../nan/nan.h:1066:53: warning: ‘v8::Local<v8::String> v8::Value::ToString() const’ is deprecated: Use maybe version [-Wdeprecated-declarations]
Mon Oct 22 15:22:40 UTC 2018: v8::Local<v8::String> string = from->ToString();
Mon Oct 22 15:22:40 UTC 2018: ^
Mon Oct 22 15:22:40 UTC 2018: In file included from /.nvm/versions/node/v10.12.0/include/node/v8-profiler.h:10:0,
Mon Oct 22 15:22:40 UTC 2018: from ../bindings/sampling-heap-profiler.cc:18:
Mon Oct 22 15:22:40 UTC 2018: /.nvm/versions/node/v10.12.0/include/node/v8.h:10040:15: note: declared here
Mon Oct 22 15:22:40 UTC 2018: Local<String> Value::ToString() const {
Mon Oct 22 15:22:40 UTC 2018: ^~~~~
Mon Oct 22 15:22:40 UTC 2018: In file included from ../bindings/sampling-heap-profiler.cc:19:0:
Mon Oct 22 15:22:40 UTC 2018: ../../../nan/nan.h:1080:74: warning: ‘int v8::String::WriteUtf8(char*, int, int*, int) const’ is deprecated: Use Isolate* version [-Wdeprecated-declarations]
Mon Oct 22 15:22:40 UTC 2018: length_ = string->WriteUtf8(str_, static_cast<int>(len), 0, flags);
Mon Oct 22 15:22:40 UTC 2018: ^
Mon Oct 22 15:22:40 UTC 2018: In file included from /.nvm/versions/node/v10.12.0/include/node/v8.h:26:0,
Mon Oct 22 15:22:40 UTC 2018: from /.nvm/versions/node/v10.12.0/include/node/v8-profiler.h:10,
Mon Oct 22 15:22:40 UTC 2018: from ../bindings/sampling-heap-profiler.cc:18:
Mon Oct 22 15:22:40 UTC 2018: /.nvm/versions/node/v10.12.0/include/node/v8.h:2659:21: note: declared here
Mon Oct 22 15:22:40 UTC 2018: int WriteUtf8(char* buffer, int length = -1,
Mon Oct 22 15:22:40 UTC 2018: ^
Mon Oct 22 15:22:40 UTC 2018: /.nvm/versions/node/v10.12.0/include/node/v8config.h:324:3: note: in definition of macro ‘V8_DEPRECATED’
Mon Oct 22 15:22:40 UTC 2018: declarator __attribute__((deprecated(message)))
Mon Oct 22 15:22:40 UTC 2018: ^~~~~~~~~~
Mon Oct 22 15:22:40 UTC 2018: ../bindings/sampling-heap-profiler.cc: In function ‘Nan::NAN_METHOD_RETURN_TYPE StartSamplingHeapProfiler(Nan::NAN_METHOD_ARGS_TYPE)’:
Mon Oct 22 15:22:40 UTC 2018: ../bindings/sampling-heap-profiler.cc:69:67: warning: ‘uint32_t v8::Value::Uint32Value() const’ is deprecated: Use maybe version [-Wdeprecated-declarations]
Mon Oct 22 15:22:40 UTC 2018: uint64_t sample_interval = info[0].As<Integer>()->Uint32Value();
Mon Oct 22 15:22:40 UTC 2018: ^
Mon Oct 22 15:22:40 UTC 2018: In file included from /.nvm/versions/node/v10.12.0/include/node/v8.h:26:0,
Mon Oct 22 15:22:40 UTC 2018: from /.nvm/versions/node/v10.12.0/include/node/v8-profiler.h:10,
Mon Oct 22 15:22:40 UTC 2018: from ../bindings/sampling-heap-profiler.cc:18:
Mon Oct 22 15:22:40 UTC 2018: /.nvm/versions/node/v10.12.0/include/node/v8.h:2477:47: note: declared here
Mon Oct 22 15:22:40 UTC 2018: V8_DEPRECATED("Use maybe version", uint32_t Uint32Value() const);
Mon Oct 22 15:22:40 UTC 2018: ^
Mon Oct 22 15:22:40 UTC 2018: /.nvm/versions/node/v10.12.0/include/node/v8config.h:324:3: note: in definition of macro ‘V8_DEPRECATED’
Mon Oct 22 15:22:40 UTC 2018: declarator __attribute__((deprecated(message)))
Mon Oct 22 15:22:40 UTC 2018: ^~~~~~~~~~
Mon Oct 22 15:22:40 UTC 2018: ../bindings/sampling-heap-profiler.cc:70:59: warning: ‘int64_t v8::Value::IntegerValue() const’ is deprecated: Use maybe version [-Wdeprecated-declarations]
Mon Oct 22 15:22:40 UTC 2018: int stack_depth = info[1].As<Integer>()->IntegerValue();
Mon Oct 22 15:22:40 UTC 2018: ^
Mon Oct 22 15:22:40 UTC 2018: In file included from /.nvm/versions/node/v10.12.0/include/node/v8.h:26:0,
Mon Oct 22 15:22:40 UTC 2018: from /.nvm/versions/node/v10.12.0/include/node/v8-profiler.h:10,
Mon Oct 22 15:22:40 UTC 2018: from ../bindings/sampling-heap-profiler.cc:18:
Mon Oct 22 15:22:40 UTC 2018: /.nvm/versions/node/v10.12.0/include/node/v8.h:2476:46: note: declared here
Mon Oct 22 15:22:40 UTC 2018: V8_DEPRECATED("Use maybe version", int64_t IntegerValue() const);
Mon Oct 22 15:22:40 UTC 2018: ^
Mon Oct 22 15:22:40 UTC 2018: /.nvm/versions/node/v10.12.0/include/node/v8config.h:324:3: note: in definition of macro ‘V8_DEPRECATED’
Mon Oct 22 15:22:40 UTC 2018: declarator __attribute__((deprecated(message)))
Mon Oct 22 15:22:40 UTC 2018: ^~~~~~~~~~
Mon Oct 22 15:22:41 UTC 2018: In file included from ../../../nan/nan_new.h:189:0,
Mon Oct 22 15:22:41 UTC 2018: from ../../../nan/nan.h:222,
Mon Oct 22 15:22:41 UTC 2018: from ../bindings/time-profiler.cc:18:
Mon Oct 22 15:22:41 UTC 2018: ../../../nan/nan_implementation_12_inl.h: In static member function ‘static Nan::imp::FactoryBase<v8::StringObject>::return_t Nan::imp::Factory<v8::StringObject>::New(v8::Local<v8::String>)’:
Mon Oct 22 15:22:41 UTC 2018: ../../../nan/nan_implementation_12_inl.h:340:37: warning: ‘static v8::Local<v8::Value> v8::StringObject::New(v8::Local<v8::String>)’ is deprecated: Use Isolate* version [-Wdeprecated-declarations]
Mon Oct 22 15:22:41 UTC 2018: return v8::StringObject::New(value).As<v8::StringObject>();
Mon Oct 22 15:22:41 UTC 2018: ^
Mon Oct 22 15:22:41 UTC 2018: In file included from /.nvm/versions/node/v10.12.0/include/node/v8.h:26:0,
Mon Oct 22 15:22:41 UTC 2018: from /.nvm/versions/node/v10.12.0/include/node/v8-profiler.h:10,
Mon Oct 22 15:22:41 UTC 2018: from ../bindings/time-profiler.cc:17:
Mon Oct 22 15:22:41 UTC 2018: /.nvm/versions/node/v10.12.0/include/node/v8.h:5053:37: note: declared here
Mon Oct 22 15:22:41 UTC 2018: static Local<Value> New(Local<String> value));
Mon Oct 22 15:22:41 UTC 2018: ^
Mon Oct 22 15:22:41 UTC 2018: /.nvm/versions/node/v10.12.0/include/node/v8config.h:324:3: note: in definition of macro ‘V8_DEPRECATED’
Mon Oct 22 15:22:41 UTC 2018: declarator __attribute__((deprecated(message)))
Mon Oct 22 15:22:41 UTC 2018: ^~~~~~~~~~
Mon Oct 22 15:22:41 UTC 2018: In file included from ../bindings/time-profiler.cc:18:0:
Mon Oct 22 15:22:41 UTC 2018: ../../../nan/nan.h: In constructor ‘Nan::Utf8String::Utf8String(v8::Local<v8::Value>)’:
Mon Oct 22 15:22:41 UTC 2018: ../../../nan/nan.h:1066:53: warning: ‘v8::Local<v8::String> v8::Value::ToString() const’ is deprecated: Use maybe version [-Wdeprecated-declarations]
Mon Oct 22 15:22:41 UTC 2018: v8::Local<v8::String> string = from->ToString();
Mon Oct 22 15:22:41 UTC 2018: ^
Mon Oct 22 15:22:41 UTC 2018: In file included from /.nvm/versions/node/v10.12.0/include/node/v8-profiler.h:10:0,
Mon Oct 22 15:22:41 UTC 2018: from ../bindings/time-profiler.cc:17:
Mon Oct 22 15:22:41 UTC 2018: /.nvm/versions/node/v10.12.0/include/node/v8.h:10040:15: note: declared here
Mon Oct 22 15:22:41 UTC 2018: Local<String> Value::ToString() const {
Mon Oct 22 15:22:41 UTC 2018: ^~~~~
Mon Oct 22 15:22:41 UTC 2018: In file included from ../bindings/time-profiler.cc:18:0:
Mon Oct 22 15:22:41 UTC 2018: ../../../nan/nan.h:1080:74: warning: ‘int v8::String::WriteUtf8(char*, int, int*, int) const’ is deprecated: Use Isolate* version [-Wdeprecated-declarations]
Mon Oct 22 15:22:41 UTC 2018: length_ = string->WriteUtf8(str_, static_cast<int>(len), 0, flags);
Mon Oct 22 15:22:41 UTC 2018: ^
Mon Oct 22 15:22:41 UTC 2018: In file included from /.nvm/versions/node/v10.12.0/include/node/v8.h:26:0,
Mon Oct 22 15:22:41 UTC 2018: from /.nvm/versions/node/v10.12.0/include/node/v8-profiler.h:10,
Mon Oct 22 15:22:41 UTC 2018: from ../bindings/time-profiler.cc:17:
Mon Oct 22 15:22:41 UTC 2018: /.nvm/versions/node/v10.12.0/include/node/v8.h:2659:21: note: declared here
Mon Oct 22 15:22:41 UTC 2018: int WriteUtf8(char* buffer, int length = -1,
Mon Oct 22 15:22:41 UTC 2018: ^
Mon Oct 22 15:22:41 UTC 2018: /.nvm/versions/node/v10.12.0/include/node/v8config.h:324:3: note: in definition of macro ‘V8_DEPRECATED’
Mon Oct 22 15:22:41 UTC 2018: declarator __attribute__((deprecated(message)))
Mon Oct 22 15:22:41 UTC 2018: ^~~~~~~~~~
Mon Oct 22 15:22:41 UTC 2018: ../bindings/time-profiler.cc: In function ‘Nan::NAN_METHOD_RETURN_TYPE SetSamplingInterval(Nan::NAN_METHOD_ARGS_TYPE)’:
Mon Oct 22 15:22:41 UTC 2018: ../bindings/time-profiler.cc:89:48: warning: ‘int64_t v8::Value::IntegerValue() const’ is deprecated: Use maybe version [-Wdeprecated-declarations]
Mon Oct 22 15:22:41 UTC 2018: int us = info[0].As<Integer>()->IntegerValue();
Mon Oct 22 15:22:41 UTC 2018: ^
Mon Oct 22 15:22:41 UTC 2018: In file included from /.nvm/versions/node/v10.12.0/include/node/v8.h:26:0,
Mon Oct 22 15:22:41 UTC 2018: from /.nvm/versions/node/v10.12.0/include/node/v8-profiler.h:10,
Mon Oct 22 15:22:41 UTC 2018: from ../bindings/time-profiler.cc:17:
Mon Oct 22 15:22:41 UTC 2018: /.nvm/versions/node/v10.12.0/include/node/v8.h:2476:46: note: declared here
Mon Oct 22 15:22:41 UTC 2018: V8_DEPRECATED("Use maybe version", int64_t IntegerValue() const);
Mon Oct 22 15:22:41 UTC 2018: ^
Mon Oct 22 15:22:41 UTC 2018: /.nvm/versions/node/v10.12.0/include/node/v8config.h:324:3: note: in definition of macro ‘V8_DEPRECATED’
Mon Oct 22 15:22:41 UTC 2018: declarator __attribute__((deprecated(message)))
Mon Oct 22 15:22:41 UTC 2018: ^~~~~~~~~~
Mon Oct 22 15:22:41 UTC 2018: npm notice created a lockfile as package-lock.json. You should commit this file.
Mon Oct 22 15:22:41 UTC 2018: npm WARN @0.0.0 No description
Mon Oct 22 15:22:41 UTC 2018: npm WARN @0.0.0 No repository field.
Mon Oct 22 15:22:41 UTC 2018: 
Mon Oct 22 15:22:41 UTC 2018: + return 0
Mon Oct 22 15:22:41 UTC 2018: + retry npm install
Mon Oct 22 15:22:41 UTC 2018: + for i in {1..3}
Mon Oct 22 15:22:41 UTC 2018: + npm install
Mon Oct 22 15:22:47 UTC 2018: npm WARN lifecycle @0.0.0~prepare: cannot run in wd @0.0.0 npm run compile (wd=/test/busybench)
Mon Oct 22 15:22:47 UTC 2018: npm WARN @0.0.0 No description
Mon Oct 22 15:22:47 UTC 2018: npm WARN @0.0.0 No repository field.

The text was updated successfully, but these errors were encountered:

nolanmar511 · 2018-10-22T16:24:16Z

@aalexand, I changed the node version in the title, based on the nodedir used. Correct me if I switched to the wrong node version.

aalexand · 2018-10-22T16:28:09Z

@nolanmar511 Ah, thanks, yes it was a mistake.

nolanmar511 · 2018-10-23T19:28:58Z

The ones originating from our files should be fixed by #318.

Most of these we need NAN to address (nodejs/nan#810)

BrianChristie · 2018-11-20T10:17:42Z

Can we get a release made with at least the fixes from #318 while waiting for NAN to address the remaining issues?

nolanmar511 · 2018-11-20T20:54:31Z

Thanks!
We just released 0.2.3!

aalexand · 2018-12-08T18:22:30Z

@nolanmar511 The latest released agent still has the deprecation warnings from its compilation - what's the status?

nolanmar511 · 2018-12-10T15:31:48Z

nodejs/nan#810 has been fixed, but not released since that fix.

I asked on that issue for a new release of NAN.

nolanmar511 · 2019-01-09T20:52:59Z

With latest version of NAN installed, no deprecation warnings appear on master when using 10.12.0.

Marking this as fixed.

aalexand · 2019-01-09T21:44:01Z

@nolanmar511 Are prober logs also free of deprecation warnings now?

nolanmar511 · 2019-01-09T22:10:38Z

Still seeing the deprecation warnings in prober logs.

I think we'd have to do a release.
The latest release uses an 2.11.1, and the necessary fixes weren't all present in nan until 2.12.1

nolanmar511 · 2019-01-28T17:37:36Z

Installing the latest version of @google-cloud/profiler with 10.12.0 (or with 10.15.0) does not have any deprecation warnings.

Closing this.

nolanmar511 · 2019-01-28T18:06:58Z

Re-opening.

I still see warnings in our prober.

nolanmar511 · 2019-02-25T18:30:29Z

I reproduced an an ubuntu GCE instance. For reference, here are deprecation warnings:

make: Entering directory '/home/nolanmar/tmp/node_modules/@google-cloud/profiler/build'
  CXX(target) Release/obj.target/google_cloud_profiler/bindings/profiler.o
In file included from ../bindings/profiler.cc:18:
../../../nan/nan.h: In function ‘void Nan::AsyncQueueWorker(Nan::AsyncWorker*)’:
../../../nan/nan.h:2232:62: warning: cast between incompatible function types from ‘void (*)(uv_work_t*)’ {aka ‘void (*)(uv_work_s*)’} to ‘uv_after_work_cb’ {aka ‘void (*)(uv_work_s*, int)’} [-Wcast-function-type]
     , reinterpret_cast<uv_after_work_cb>(AsyncExecuteComplete)
                                                              ^
In file included from ../../../nan/nan.h:53,
                 from ../bindings/profiler.cc:18:
../bindings/profiler.cc: At global scope:
/home/nolanmar/.node-gyp/10.15.1/include/node/node.h:570:43: warning: cast between incompatible function types from ‘void (*)(Nan::ADDON_REGISTER_FUNCTION_ARGS_TYPE)’ {aka ‘void (*)(v8::Local<v8::Object>)’} to ‘node::addon_register_func’ {aka ‘void (*)(v8::Local<v8::Object>, v8::Local<v8::Value>, void*)’} [-Wcast-function-type]
       (node::addon_register_func) (regfunc),                          \
                                           ^
/home/nolanmar/.node-gyp/10.15.1/include/node/node.h:604:3: note: in expansion of macro ‘NODE_MODULE_X’
   NODE_MODULE_X(modname, regfunc, NULL, 0)  // NOLINT (readability/null_usage)
   ^~~~~~~~~~~~~
../bindings/profiler.cc:189:1: note: in expansion of macro ‘NODE_MODULE’
 NODE_MODULE(google_cloud_profiler, InitAll);
 ^~~~~~~~~~~
In file included from /home/nolanmar/.node-gyp/10.15.1/include/node/v8-profiler.h:10,
                 from ../bindings/profiler.cc:17:
/home/nolanmar/.node-gyp/10.15.1/include/node/v8.h: In instantiation of ‘void v8::PersistentBase<T>::SetWeak(P*, typename v8::WeakCallbackInfo<P>::Callback, v8::WeakCallbackType) [with P = node::ObjectWrap; T = v8::Object; typename v8::WeakCallbackInfo<P>::Callback = void (*)(const v8::WeakCallbackInfo<node::ObjectWrap>&)]’:
/home/nolanmar/.node-gyp/10.15.1/include/node/node_object_wrap.h:85:78:   required from here
/home/nolanmar/.node-gyp/10.15.1/include/node/v8.h:9502:16: warning: cast between incompatible function types from ‘v8::WeakCallbackInfo<node::ObjectWrap>::Callback’ {aka ‘void (*)(const v8::WeakCallbackInfo<node::ObjectWrap>&)’} to ‘Callback’ {aka ‘void (*)(const v8::WeakCallbackInfo<void>&)’} [-Wcast-function-type]
                reinterpret_cast<Callback>(callback), type);
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/nolanmar/.node-gyp/10.15.1/include/node/v8.h: In instantiation of ‘void v8::PersistentBase<T>::SetWeak(P*, typename v8::WeakCallbackInfo<P>::Callback, v8::WeakCallbackType) [with P = Nan::ObjectWrap; T = v8::Object; typename v8::WeakCallbackInfo<P>::Callback = void (*)(const v8::WeakCallbackInfo<Nan::ObjectWrap>&)]’:
../../../nan/nan_object_wrap.h:66:61:   required from here
/home/nolanmar/.node-gyp/10.15.1/include/node/v8.h:9502:16: warning: cast between incompatible function types from ‘v8::WeakCallbackInfo<Nan::ObjectWrap>::Callback’ {aka ‘void (*)(const v8::WeakCallbackInfo<Nan::ObjectWrap>&)’} to ‘Callback’ {aka ‘void (*)(const v8::WeakCallbackInfo<void>&)’} [-Wcast-function-type]

nolanmar511 · 2019-02-26T19:20:00Z

Re-purposing this issue to be about removing the suppression of warnings added in #424 .

nolanmar511 · 2019-03-04T21:44:19Z

Removed from Beta hotlist, since this issue has been re-purposed and original deprecation warnings no longer appear.

nolanmar511 · 2019-05-15T20:57:21Z

Marking this as fixed since native component is now in pprof module.
I filed google/pprof-nodejs#63 there.

aalexand assigned nolanmar511 Oct 22, 2018

nolanmar511 changed the title ~~Deprecation warnings in node 0.10.2 builds~~ Deprecation warnings in node 10.12.0 builds Oct 22, 2018

JustinBeckwith added the triage me I really want to be triaged. label Oct 23, 2018

nolanmar511 added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed triage me I really want to be triaged. labels Oct 23, 2018

nolanmar511 mentioned this issue Oct 23, 2018

chore: stop using methods with deprecation warnings in node 10.12.0 #318

Merged

aalexand added this to the Agent Beta milestone Dec 8, 2018

nolanmar511 modified the milestone: Agent Beta Dec 20, 2018

nolanmar511 closed this as completed Jan 9, 2019

aalexand reopened this Jan 9, 2019

nolanmar511 changed the title ~~Deprecation warnings in node 10.12.0 builds~~ Deprecation warnings in node 10.15.0 builds Jan 25, 2019

nolanmar511 closed this as completed Jan 28, 2019

nolanmar511 reopened this Jan 28, 2019

nolanmar511 mentioned this issue Feb 25, 2019

chore: silence deprecation warnings that appear with gcc 8 #424

Merged

nolanmar511 changed the title ~~Deprecation warnings in node 10.15.0 builds~~ Stop suppressing deprecation warnings with -Wno-cast-function-type Feb 26, 2019

nolanmar511 changed the title ~~Stop suppressing deprecation warnings with -Wno-cast-function-type~~ Stop suppressing warnings with -Wno-cast-function-type Feb 26, 2019

nolanmar511 added the type: cleanup An internal cleanup or hygiene concern. label Feb 27, 2019

nolanmar511 removed this from the Agent Beta milestone Mar 4, 2019

yoshi-automation added the 🚨 This issue needs some love. label Apr 20, 2019

sduskis removed 🚨 This issue needs some love. priority: p2 Moderately-important priority. Fix may not be included in next release. labels May 13, 2019

nolanmar511 mentioned this issue May 15, 2019

Stop suppressing warnings with -Wno-cast-function-type google/pprof-nodejs#62

Open

nolanmar511 closed this as completed May 15, 2019

google-cloud-label-sync bot added the api: cloudprofiler Issues related to the googleapis/cloud-profiler-nodejs API. label Jan 31, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stop suppressing warnings with -Wno-cast-function-type #315

Stop suppressing warnings with -Wno-cast-function-type #315

aalexand commented Oct 22, 2018

nolanmar511 commented Oct 22, 2018

aalexand commented Oct 22, 2018

nolanmar511 commented Oct 23, 2018

BrianChristie commented Nov 20, 2018

nolanmar511 commented Nov 20, 2018

aalexand commented Dec 8, 2018

nolanmar511 commented Dec 10, 2018

nolanmar511 commented Jan 9, 2019 •

edited

Loading

aalexand commented Jan 9, 2019

nolanmar511 commented Jan 9, 2019

nolanmar511 commented Jan 28, 2019

nolanmar511 commented Jan 28, 2019

nolanmar511 commented Feb 25, 2019

nolanmar511 commented Feb 26, 2019

nolanmar511 commented Mar 4, 2019

nolanmar511 commented May 15, 2019

Stop suppressing warnings with -Wno-cast-function-type #315

Stop suppressing warnings with -Wno-cast-function-type #315

Comments

aalexand commented Oct 22, 2018

nolanmar511 commented Oct 22, 2018

aalexand commented Oct 22, 2018

nolanmar511 commented Oct 23, 2018

BrianChristie commented Nov 20, 2018

nolanmar511 commented Nov 20, 2018

aalexand commented Dec 8, 2018

nolanmar511 commented Dec 10, 2018

nolanmar511 commented Jan 9, 2019 • edited Loading

aalexand commented Jan 9, 2019

nolanmar511 commented Jan 9, 2019

nolanmar511 commented Jan 28, 2019

nolanmar511 commented Jan 28, 2019

nolanmar511 commented Feb 25, 2019

nolanmar511 commented Feb 26, 2019

nolanmar511 commented Mar 4, 2019

nolanmar511 commented May 15, 2019

nolanmar511 commented Jan 9, 2019 •

edited

Loading