You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Further investigation also showed it depends on which functions used for representation:
# go jsonnet
❯ nix run nixpkgs#go-jsonnet -- -e "std.manifestJson(0.97)"
"0.97"
❯ nix run nixpkgs#go-jsonnet -- -e "std.toString(0.97)"
"0.96999999999999997"
❯ nix run nixpkgs#go-jsonnet -- -e 0.97
0.96999999999999997
# c++ jsonnet
❯ nix run nixpkgs#jsonnet -- -e "std.manifestJson(0.97)"
"0.96999999999999997"
❯ nix run nixpkgs#jsonnet -- -e "std.toString(0.97)"
"0.96999999999999997"
❯ nix run nixpkgs#jsonnet -- -e 0.97
0.96999999999999997
# rust jrsonnet
❯ cargo run -- -e "std.manifestJson(0.97)"
"0.97"
❯ cargo run -- -e "std.toString(0.97)"
"0.97"
❯ cargo run -- -e 0.97
0.97
@sparkprime suggest using the short version in Go:
My preference would be for the shortest exact string. There was no way to do that in C++ and we matched that behaviour in Go. Given we're trying to move people off of C++ to Go it may be a good time to switch Go over to the shorter output.
Initially I've only encountered this when using jrsonnet directly but we are working on a feature in Tanka to use the rust version alongside the Go version and this causes a massive diff on our code base. It would be nice if we could get this fixed in the Go version so we can get rid of the diff and keep our sanity.
The text was updated successfully, but these errors were encountered:
Downstream issue: CertainLach/jrsonnet#108
Decimal numbers are displayed differently depending on the implementation.
Further investigation also showed it depends on which functions used for representation:
@sparkprime suggest using the short version in Go:
Initially I've only encountered this when using jrsonnet directly but we are working on a feature in Tanka to use the rust version alongside the Go version and this causes a massive diff on our code base. It would be nice if we could get this fixed in the Go version so we can get rid of the diff and keep our sanity.
The text was updated successfully, but these errors were encountered: