Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

Tools seems to be broken #3

Closed
dmolineus opened this issue Oct 30, 2014 · 13 comments
Closed

Tools seems to be broken #3

dmolineus opened this issue Oct 30, 2014 · 13 comments

Comments

@dmolineus
Copy link

I've tried your online tool. Unfortunately I get an error message than click on move issue:

Error creating new issue: NullError: Cannot call "ez" on null

It happens if i want to move one issue between two personal issues and also when trying to move an issue between 2 repos which belongs to an organization.

@nicolasgarnier
Copy link
Contributor

Hey @dmolineus the tool seem to work fine for me and some colleagues. We need to figure out what's different with your setup :)

It would help a lot if you could tell me:

  • what browser and version you are using?
  • could you describe what you did step-by step just in case?
  • Do you see the details of the issue and the selected repo displayed below the input field like that:

image

Alternatively you could try again with the Dartium browser (download here: https://www.dartlang.org/tools/download.html) which will execute the Dart code instead of the minified JS so we'll know where exactly in the code this is failing :)

Cheers!

@nicolasgarnier
Copy link
Contributor

Thanks for the report by the way :) There are certainly unfixed bugs since the tool is so new. It's awesome if you can help fix this one!

@dmolineus
Copy link
Author

Selecting the repositories is working so far. But after clicking "move issue" I get following error. I also get some 404 errors occuring in the browser dev toolbar. In fact, then loading these files with curl I get a http state 200. Strange...

I've only tried your only tool https://github-issue-mover.appspot.com/ so far. Maybe try my own copy.

I'm using a Google chrome browser (38.0.2125.111) with ubuntu linux.

auswahl_004
auswahl_005
auswahl_006

@nicolasgarnier
Copy link
Contributor

Strange! :D for sure the 404 failures are what is causing the error. Are there some characters missing on the URL on the right? Could you tell me what are the 2 full URLs shown in the JS console?

@brainstorm
Copy link

I am also getting a similar error:

skarmavbild 2014-11-04 kl 10 16 49

@cycomachead
Copy link

Just want to report that I'm also seeing the same 404's. I tried a couple different repo's of mine (Organization repos, not individual ones) and saw errors regardless of the browser I used.

@nicolasgarnier
Copy link
Contributor

Hey guys,

(back from vacations, sorry for the delay)

Just found out what the issue is:

The GitHub.dart client library that I am using has a bug (just filed and fixed SpinlockLabs/github.dart#45) where an incorrect URL parameter ("scopes" instead of "scope") was being used when doing the OAuth 2.0 authorization request.

Me and my colleagues didn't see it because we've all authorized the tool a while ago when I was using my own OAuth 2 implementation for Github (then I switched to using the one from the GItHub.dart library).

This resulted in you guys not granting permission to read+write on your repos (only read public info which is the default). Therefore trying to create the initial issue failed because we lacked write permissions.

And to complicate things the error code from the GitHub API (404) is incorrect/misleading. GitHub should return a 403 (Forbidden) error code instead (unless the repo is private).

Also Github.dart does not throw a meaningful exception when a permission error happens (instead we get the NPO you guys experiences). Filed SpinlockLabs/github.dart#47

@nicolasgarnier
Copy link
Contributor

I'm pushing a new version of the tool that should fix this.

@brainstorm
Copy link

Fantastic! Please let us know when it's deployed, up and running 👍

@nicolasgarnier
Copy link
Contributor

Done!

If your session is still opened Do;t forget to click the "logout" link on the top right to make sure your token is removed from the session and you request a new one.

Cheers!

@brainstorm
Copy link

Fantastic! It now works like a charm 👍

@ahundt
Copy link

ahundt commented Mar 30, 2015

I still get this error and it seems there is another issue dedicated to this:
#11

@boelle
Copy link

boelle commented Aug 3, 2015

yep i just ran in to it today

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants