Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VulkanTerminator doesn't handle subcommand indices changing between Add and Transform #2010

Closed
sean-purcell opened this issue Jun 20, 2018 · 1 comment
Assignees

Comments

@sean-purcell
Copy link
Contributor

When using dead code elimination in vulkan replays, the subcommand index for the last subcommand in the replay request can change if commands in the buffer were removed. This means the terminator can end up including extra commands in the buffer.

@AWoloszyn
Copy link
Contributor

IIRC (And @Qining , please correct me if I am wrong) the DCE keeps all commands in the last queue submission alive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants