Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long Non-Editable Comments Are Hard to Read #2917

Closed
BeksOmega opened this issue Aug 26, 2019 · 0 comments · Fixed by #8632
Closed

Long Non-Editable Comments Are Hard to Read #2917

BeksOmega opened this issue Aug 26, 2019 · 0 comments · Fixed by #8632
Assignees
Labels
component: bubbles component: comments issue: bug Describes why the code or behaviour is wrong
Milestone

Comments

@BeksOmega
Copy link
Collaborator

BeksOmega commented Aug 26, 2019

Describe the bug

If you have a comment that is long, and you display it in readonly/non-editable mode, it is all rendered on one line and flows off the workspace bounds.

To Reproduce

Steps to reproduce the behavior:

  1. Set the playground to readonly.
  2. Load the following xml in the playground:
<xml xmlns="https://developers.google.com/blockly/xml">
  <block type="controls_if" editable="false">
    <comment pinned="true" h="32" w="1009.015625">This is a long comment of longness with lots and lots of text and leeettttteerrrrssss. And also some more text to help demonstrate non-editable comments.</comment>
  </block>
</xml>
  1. Observe how the comment is hard to read.

Expected behavior

The non-editable UI should try not to flow off the screen, ideally it would try to obey the height and width of the comment.

Screenshots

Editable:
EditableComment
Non-Editable:
NonEditableComment

This is not browser specific.

Additional context

The non-editable comment ui is using the warning UI.

Warnings already support linebreaks, so maybe that could be useful.

[EDIT: Related to #2943]

@BeksOmega BeksOmega added issue: triage Issues awaiting triage by a Blockly team member issue: bug Describes why the code or behaviour is wrong labels Aug 26, 2019
@rachel-fenichel rachel-fenichel added component: bubbles component: comments and removed issue: triage Issues awaiting triage by a Blockly team member labels Aug 28, 2019
@gonfunko gonfunko self-assigned this Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: bubbles component: comments issue: bug Describes why the code or behaviour is wrong
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants