-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functionality to clear shader #1860
base: main
Are you sure you want to change the base?
Conversation
51e51fc
to
6e143ad
Compare
Snapshot diff report vs base branch: main |
6e143ad
to
849dabe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking that there would be a button next to "Apply Shader" to clear a single node of its shader, instead of, or in addition to, this method of clearing all shaders. A user might have a few shaders in a document and then accidentally apply a shader on the wrong node, in which case there's no way to just remove the shader from that node without clearing all shaders.
Secondly, I don't think there is a way right now to tell if a node has a shader set on it. I think that the shader UI should have some indication that the currently selected node has a shader saved in it, and a way to load that shader code into the text edit box.
849dabe
to
f585370
Compare
72ea034
to
212f791
Compare
Good point. Filed a ticket #1877 to track the load shader code in the plugin ui(including update the clear shader button state) |
212f791
to
e1a690f
Compare
e1a690f
to
8f78105
Compare
Fixes: #1714