Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up batch vs single error handling #147

Open
jcoatgoogle opened this issue Mar 6, 2017 · 0 comments
Open

Clean up batch vs single error handling #147

jcoatgoogle opened this issue Mar 6, 2017 · 0 comments

Comments

@jcoatgoogle
Copy link
Contributor

#145

So, this change further increases the delta between error handling in the batch and non-batch case... after discussing with @craigcitro, in the short term we can probably update BatchHttpRequest#_Execute to use each request's check_response_func
https://github.com/google/apitools/blob/master/apitools/base/py/batch.py#L409
and in the longer run, we should further unify the code of a batch and non batch request (and the error handling)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant