Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this portion of attention code looks incorrect #245

Open
ava6969 opened this issue Jun 14, 2022 · 0 comments
Open

this portion of attention code looks incorrect #245

ava6969 opened this issue Jun 14, 2022 · 0 comments

Comments

@ava6969
Copy link

ava6969 commented Jun 14, 2022

attention_mlp = basic.BatchApply( mlp.MLP([self._mem_size] * self._attention_mlp_layers))

for _ in range(self._num_blocks): attended_memory = self._multihead_attention(memory)

shouldnt it be this

attended_memory = memory
for _ in range(self._num_blocks):
attended_memory = self._multihead_attention(attended_memory)

i know memory isn't changed in that function too, so isn't this expected to be redundant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant