From dfc07e0e0c6e737a56a5402644265f634402b864 Mon Sep 17 00:00:00 2001 From: David Jacot Date: Tue, 17 Dec 2024 20:09:45 +0100 Subject: [PATCH] KAFKA-17960; PlaintextAdminIntegrationTest.testConsumerGroups fails with CONSUMER group protocol (#18234) The issue has been fixed by https://issues.apache.org/jira/browse/KAFKA-18188. We can re-enable the test with the CONSUMER protocol. Reviewers: Lianet Magrans , Andrew Schofield --- .../integration/kafka/api/PlaintextAdminIntegrationTest.scala | 4 ++-- .../scala/integration/kafka/server/QuorumTestHarness.scala | 3 --- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala b/core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala index 890aff6da1edb..e62ffdf7ff799 100644 --- a/core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala +++ b/core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala @@ -1810,7 +1810,7 @@ class PlaintextAdminIntegrationTest extends BaseAdminIntegrationTest { * Test the consumer group APIs. */ @ParameterizedTest(name = TestInfoUtils.TestWithParameterizedQuorumAndGroupProtocolNames) - @MethodSource(Array("getTestQuorumAndGroupProtocolParametersClassicGroupProtocolOnly_KAFKA_17960")) + @MethodSource(Array("getTestQuorumAndGroupProtocolParametersAll")) def testConsumerGroups(quorum: String, groupProtocol: String): Unit = { val config = createConfig client = Admin.create(config) @@ -2167,7 +2167,7 @@ class PlaintextAdminIntegrationTest extends BaseAdminIntegrationTest { * Test the consumer group APIs. */ @ParameterizedTest(name = TestInfoUtils.TestWithParameterizedQuorumAndGroupProtocolNames) - @MethodSource(Array("getTestQuorumAndGroupProtocolParametersClassicGroupProtocolOnly_KAFKA_17960")) + @MethodSource(Array("getTestQuorumAndGroupProtocolParametersAll")) def testConsumerGroupsDeprecatedConsumerGroupState(quorum: String, groupProtocol: String): Unit = { val config = createConfig client = Admin.create(config) diff --git a/core/src/test/scala/integration/kafka/server/QuorumTestHarness.scala b/core/src/test/scala/integration/kafka/server/QuorumTestHarness.scala index 9c9067ef1132c..a8a66dbd54f5c 100755 --- a/core/src/test/scala/integration/kafka/server/QuorumTestHarness.scala +++ b/core/src/test/scala/integration/kafka/server/QuorumTestHarness.scala @@ -444,8 +444,5 @@ object QuorumTestHarness { // The following parameter groups are to *temporarily* avoid bugs with the CONSUMER group protocol Consumer // implementation that would otherwise cause tests to fail. - def getTestQuorumAndGroupProtocolParametersClassicGroupProtocolOnly_KAFKA_17960: stream.Stream[Arguments] = getTestQuorumAndGroupProtocolParametersClassicGroupProtocolOnly - def getTestQuorumAndGroupProtocolParametersClassicGroupProtocolOnly_KAFKA_17961: stream.Stream[Arguments] = getTestQuorumAndGroupProtocolParametersClassicGroupProtocolOnly - def getTestQuorumAndGroupProtocolParametersClassicGroupProtocolOnly_KAFKA_17964: stream.Stream[Arguments] = getTestQuorumAndGroupProtocolParametersClassicGroupProtocolOnly def getTestQuorumAndGroupProtocolParametersClassicGroupProtocolOnly_KAFKA_18034: stream.Stream[Arguments] = getTestQuorumAndGroupProtocolParametersClassicGroupProtocolOnly }