Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Targeting Go Versions For Staticcheck #1943

Closed
mneverov opened this issue Apr 29, 2021 · 1 comment · Fixed by #1946
Closed

Support Targeting Go Versions For Staticcheck #1943

mneverov opened this issue Apr 29, 2021 · 1 comment · Fixed by #1946
Labels
enhancement New feature or improvement

Comments

@mneverov
Copy link

Is your feature request related to a problem? Please describe.
I'd like golangci-lint to support targeting go versions for staticcheck.
From go 1.15 release notes:
A TestMain function is no longer required to call os.Exit. If a TestMain function returns, the test binary will call os.Exit with the value returned by m.Run.

golangci-lint --version
golangci-lint has version 1.39.0 built from 9aea4aee on 2021-03-26T08:02:53Z

When staticcheck run as a separate binary with -go 1.15 there is no errors, when run via golangci-lint:
SA3000: TestMain should call os.Exit to set exit code (staticcheck) is reported.

Describe the solution you'd like
An option to configure go version for staticcheck.

@mneverov mneverov added the enhancement New feature or improvement label Apr 29, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Apr 29, 2021

Hey, thank you for opening your first Issue ! 🙂 If you would like to contribute we have a guide for contributors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant