Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

Move gps package out of internal #1349

Merged
merged 1 commit into from
Nov 14, 2017
Merged

Move gps package out of internal #1349

merged 1 commit into from
Nov 14, 2017

Conversation

tamalsaha
Copy link
Contributor

@tamalsaha tamalsaha commented Nov 3, 2017

gomvpkg -from github.com/golang/dep/internal/gps -to github.com/golang/dep/gps

Fixes #575

@sdboyer
Copy link
Member

sdboyer commented Nov 3, 2017

(I requested this 😁)

let's see how tests so. also, @tamalsaha , I think we have an issue open for this - do you mind searching the queue for it?

/cc @spenczar - I know you were looking forward to this 😀

@tamalsaha
Copy link
Contributor Author

Added issue #. I am not sure what's wrong with codeclimate. Other tests are passing.

@tamalsaha
Copy link
Contributor Author

updated CHANGELOG

@tamalsaha
Copy link
Contributor Author

Are these tests known to be flaky? They started failing after I updated the CHANGELOG file.

@sdboyer
Copy link
Member

sdboyer commented Nov 4, 2017

the appveyor tests can be, yes. that particular failure is on a new test recently introduced for adaptive healing of the cache area. we've seen a couple other instances of flakiness from that.

the travis failure was on tip, so i'm gambling on a regression there. i've restarted both.

@sdboyer
Copy link
Member

sdboyer commented Nov 4, 2017

oh, the codeclimate failure is likely because we have some CI which knows dirs to exclude that needs to be updated.

it's worth grepping over the repo for instances of internal/gps in general (whether in *.go files or not) and seeing what may need fixing.

@tamalsaha
Copy link
Contributor Author

tamalsaha commented Nov 4, 2017

All tests are now passing except go:tip .

@carolynvs carolynvs removed their request for review November 8, 2017 01:20
`gomvpkg -from github.com/golang/dep/internal/gps -to github.com/golang/dep/gps`
Copy link
Member

@sdboyer sdboyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big shift here, but i think we're looking good!

@sdboyer sdboyer merged commit 80e94e8 into golang:master Nov 14, 2017
@tamalsaha tamalsaha deleted the gomvpkg branch November 14, 2017 00:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants